Skip to content

Update known_translations for contributor names and also fix a small issue in translate-contributors.py #16423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yhuai wants to merge 1 commit into from
Closed

Update known_translations for contributor names and also fix a small issue in translate-contributors.py #16423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions dev/create-release/known_translations
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,3 +165,40 @@ stanzhai - Stan Zhai
tien-dungle - Tien-Dung Le
xuchenCN - Xu Chen
zhangjiajin - Zhang JiaJin
ClassNotFoundExp - Fu Xing
KevinGrealish - Kevin Grealish
MasterDDT - Mitesh Patel
VinceShieh - Vincent Xie
WeichenXu123 - Weichen Xu
Yunni - Yun Ni
actuaryzhang - Wayne Zhang
alicegugu - Gu Huiqin Alice
anabranch - Bill Chambers
ashangit - Nicolas Fraison
avulanov - Alexander Ulanov
biglobster - Liang Ke
cenyuhai - Cen Yu Hai
codlife - Jianfei Wang
david-weiluo-ren - Weiluo (David) Ren
dding3 - Ding Ding
fidato13 - Tarun Kumar
frreiss - Fred Reiss
gatorsmile - Xiao Li
hayashidac - Chie Hayashida
invkrh - Hao Ren
jagadeesanas2 - Jagadeesan A S
jiangxb1987 - Jiang Xingbo
jisookim0513 - Jisoo Kim
junyangq - Junyang Qian
krishnakalyan3 - Krishna Kalyan
linbojin - Linbo Jin
mpjlu - Peng Meng
neggert - Nic Eggert
petermaxlee - Peter Lee
phalodi - Sandeep Purohit
pkch - pkch
priyankagargnitk - Priyanka Garg
sharkdtu - Sharkd Tu
shenh062326 - Shen Hong
aokolnychyi - Anton Okolnychyi
linbojin - Linbo Jin
4 changes: 3 additions & 1 deletion dev/create-release/translate-contributors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,9 @@ def generate_candidates(author, issues):
lines = contributors_file.readlines()
contributions = []
for i, line in enumerate(lines):
temp_author = line.strip(" * ").split(" -- ")[0]
# It is possible that a line in the contributor file only has the github name, e.g. yhuai.
# So, we need a strip() to remove the newline.
temp_author = line.strip(" * ").split(" -- ")[0].strip()
print "Processing author %s (%d/%d)" % (temp_author, i + 1, len(lines))
if not temp_author:
error_msg = " ERROR: Expected the following format \" * <author> -- <contributions>\"\n"
Expand Down