[Minor][Doc] Minor doc change for YARN credential providers #16444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @jerryshao |
|
Test build #70767 has finished for PR 16444 at commit
|
srowen
requested changes
Jan 1, 2017
| * | ||
| * Also each credential provider is controlled by | ||
| * spark.yarn.security.credentials.{service}.enabled, it will not be loaded in if set to false. | ||
| * E.g., hive's credential provider [[HiveCredentialProvider]] can be enable/disable by |
Member
There was a problem hiding this comment.
Nit: "For example, Hive's ..." and "can be enabled/disabled"
|
Test build #70773 has finished for PR 16444 at commit
|
Contributor
|
LGTM, thanks for the fix @viirya . |
Member
|
Merged to master/2.1 |
asfgit
pushed a commit
that referenced
this pull request
Jan 2, 2017
## What changes were proposed in this pull request?
The configuration `spark.yarn.security.tokens.{service}.enabled` is deprecated. Now we should use `spark.yarn.security.credentials.{service}.enabled`. Some places in the doc is not updated yet.
## How was this patch tested?
N/A. Just doc change.
Please review http://spark.apache.org/contributing.html before opening a pull request.
Author: Liang-Chi Hsieh <viirya@gmail.com>
Closes #16444 from viirya/minor-credential-provider-doc.
(cherry picked from commit 0ac2f1e)
Signed-off-by: Sean Owen <sowen@cloudera.com>
Member
Author
|
Thank you! @srowen @jerryshao |
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Jan 4, 2017
## What changes were proposed in this pull request?
The configuration `spark.yarn.security.tokens.{service}.enabled` is deprecated. Now we should use `spark.yarn.security.credentials.{service}.enabled`. Some places in the doc is not updated yet.
## How was this patch tested?
N/A. Just doc change.
Please review http://spark.apache.org/contributing.html before opening a pull request.
Author: Liang-Chi Hsieh <viirya@gmail.com>
Closes apache#16444 from viirya/minor-credential-provider-doc.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request?
The configuration `spark.yarn.security.tokens.{service}.enabled` is deprecated. Now we should use `spark.yarn.security.credentials.{service}.enabled`. Some places in the doc is not updated yet.
## How was this patch tested?
N/A. Just doc change.
Please review http://spark.apache.org/contributing.html before opening a pull request.
Author: Liang-Chi Hsieh <viirya@gmail.com>
Closes apache#16444 from viirya/minor-credential-provider-doc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The configuration
spark.yarn.security.tokens.{service}.enabledis deprecated. Now we should usespark.yarn.security.credentials.{service}.enabled. Some places in the doc is not updated yet.How was this patch tested?
N/A. Just doc change.
Please review http://spark.apache.org/contributing.html before opening a pull request.