[SPARK-19083]sbin/start-history-server.sh script use of $@ without quotes #16484
Conversation
|
Can one of the admins verify this patch? |
zuotingbing
changed the title
There was a problem hiding this comment.
What is the purpose of change here, from my understanding it is not related to the issue you mentioned in PR description.
There was a problem hiding this comment.
Sorry, this change is for another issue. Should i close this PR and checkout a new branch for this issue ?
There was a problem hiding this comment.
you could push another commit to this branch to revert this change.
…otes, this will affect the length of args which used in HistoryServerArguments::parse(args: List[String])
|
Would you mind checking all the scripts under |
|
@jerryshao Thank you for your advice. I checked off all the scripts under bin and sbin. It seems ok. |
|
This is the only instance I see, yes. Other instances are in dev scripts which don't matter. Could you explain what difference it makes? I read the bash reference and don't fully understand. Would it cause each individual script arg to act as if quoted? |
Yes. LGTM. Merging to master / 2.1. |
…uotes JIRA Issue: https://issues.apache.org/jira/browse/SPARK-19083# sbin/start-history-server.sh script use of $ without quotes, this will affect the length of args which used in HistoryServerArguments::parse(args: List[String]) Author: zuotingbing <zuo.tingbing9@zte.com.cn> Closes #16484 from zuotingbing/sh. (cherry picked from commit a9a1373) Signed-off-by: Marcelo Vanzin <vanzin@cloudera.com>
…uotes JIRA Issue: https://issues.apache.org/jira/browse/SPARK-19083# sbin/start-history-server.sh script use of $ without quotes, this will affect the length of args which used in HistoryServerArguments::parse(args: List[String]) Author: zuotingbing <zuo.tingbing9@zte.com.cn> Closes apache#16484 from zuotingbing/sh.
…uotes JIRA Issue: https://issues.apache.org/jira/browse/SPARK-19083# sbin/start-history-server.sh script use of $ without quotes, this will affect the length of args which used in HistoryServerArguments::parse(args: List[String]) Author: zuotingbing <zuo.tingbing9@zte.com.cn> Closes apache#16484 from zuotingbing/sh.
5 participants
JIRA Issue: https://issues.apache.org/jira/browse/SPARK-19083#
sbin/start-history-server.sh script use of $@ without quotes, this will affect the length of args which used in HistoryServerArguments::parse(args: List[String])