[SPARK-19106][DOCS] Styling for the configuration docs is broken #16490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #70986 has finished for PR 16490 at commit
|
vanzin
reviewed
Jan 6, 2017
| environment variable (see below).</p> | ||
|
|
||
| <p>It also allows a different address from the local one to be advertised to executors or external systems. | ||
| Hostname or IP address where to bind listening sockets. This config overrides the SPARK_LOCAL_IP |
Contributor
There was a problem hiding this comment.
This will now be rendered as a long paragraph, won't it? I kinda prefer having the break.
vanzin
reviewed
Jan 6, 2017
| <td>false</td> | ||
| <td> | ||
| <p>Whether to enable SSL connections on all supported protocols.</p> | ||
| Whether to enable SSL connections on all supported protocols. |
Contributor
There was a problem hiding this comment.
Same here. Long paragraph = difficult to read.
|
Test build #71010 has finished for PR 16490 at commit
|
Member
Author
|
Merged to master/2.1 |
asfgit
pushed a commit
that referenced
this pull request
Jan 7, 2017
configuration.html section headings were not specified correctly in markdown and weren't rendering, being recognized correctly. Removed extra p tags and pulled level 4 titles up to level 3, since level 3 had been skipped. This improves the TOC. Doc build, manual check. Author: Sean Owen <sowen@cloudera.com> Closes #16490 from srowen/SPARK-19106. (cherry picked from commit 54138f6) Signed-off-by: Sean Owen <sowen@cloudera.com>
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Jan 9, 2017
## What changes were proposed in this pull request? configuration.html section headings were not specified correctly in markdown and weren't rendering, being recognized correctly. Removed extra p tags and pulled level 4 titles up to level 3, since level 3 had been skipped. This improves the TOC. ## How was this patch tested? Doc build, manual check. Author: Sean Owen <sowen@cloudera.com> Closes apache#16490 from srowen/SPARK-19106.
uzadude
pushed a commit
to uzadude/spark
that referenced
this pull request
Jan 27, 2017
## What changes were proposed in this pull request? configuration.html section headings were not specified correctly in markdown and weren't rendering, being recognized correctly. Removed extra p tags and pulled level 4 titles up to level 3, since level 3 had been skipped. This improves the TOC. ## How was this patch tested? Doc build, manual check. Author: Sean Owen <sowen@cloudera.com> Closes apache#16490 from srowen/SPARK-19106.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
configuration.html section headings were not specified correctly in markdown and weren't rendering, being recognized correctly. Removed extra p tags and pulled level 4 titles up to level 3, since level 3 had been skipped. This improves the TOC.
How was this patch tested?
Doc build, manual check.