[SPARK-18871][SQL][TESTS] New test cases for IN/NOT IN subquery 2nd batch #16759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get latest code from upstream
adding trim characters support
get latest code for pr12646
merge latest code
merge upstream/master
|
Can one of the admins verify this patch? |
dilipbiswal
reviewed
Feb 1, 2017
| val1a 16 | ||
| val1a 16 | ||
| val1a 6 | ||
| val1a 6 |
Contributor
There was a problem hiding this comment.
I have compared the result set matched with the result from DB2.
dilipbiswal
reviewed
Feb 1, 2017
| 1 10 | ||
| 1 8 | ||
| 1 6 | ||
| 1 NULL |
Contributor
There was a problem hiding this comment.
I have compared the result set matched with the result from DB2.
dilipbiswal
reviewed
Feb 1, 2017
| -- !query 7 schema | ||
| struct<count(DISTINCT t1a):bigint,t1b:smallint> | ||
| -- !query 7 output | ||
| 1 6 |
Contributor
There was a problem hiding this comment.
I have compared the result set matched with the result from DB2.
Contributor
|
LGTM - merging to master |
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Feb 16, 2017
…atch ## What changes were proposed in this pull request? This is 2nd batch of test case for IN/NOT IN subquery. In this PR, it has these test cases: `in-limit.sql` `in-order-by.sql` `not-in-group-by.sql` These are the queries and results from running on DB2. [in-limit DB2 version](https://github.com/apache/spark/files/743267/in-limit.sql.db2.out.txt) [in-order-by DB2 version](https://github.com/apache/spark/files/743269/in-order-by.sql.db2.txt) [not-in-group-by DB2 version](https://github.com/apache/spark/files/743271/not-in-group-by.sql.db2.txt) [output of in-limit.sql DB2](https://github.com/apache/spark/files/743276/in-limit.sql.db2.out.txt) [output of in-order-by.sql DB2](https://github.com/apache/spark/files/743278/in-order-by.sql.db2.out.txt) [output of not-in-group-by.sql DB2](https://github.com/apache/spark/files/743279/not-in-group-by.sql.db2.out.txt) ## How was this patch tested? This pr is adding new test cases. Author: Kevin Yu <qyu@us.ibm.com> Closes apache#16759 from kevinyu98/spark-18871-2.
asfgit
pushed a commit
that referenced
this pull request
Mar 14, 2017
…ll up to Optimizer phase ## What changes were proposed in this pull request? Currently Analyzer as part of ResolveSubquery, pulls up the correlated predicates to its originating SubqueryExpression. The subquery plan is then transformed to remove the correlated predicates after they are moved up to the outer plan. In this PR, the task of pulling up correlated predicates is deferred to Optimizer. This is the initial work that will allow us to support the form of correlated subqueries that we don't support today. The design document from nsyca can be found in the following link : [DesignDoc](https://docs.google.com/document/d/1QDZ8JwU63RwGFS6KVF54Rjj9ZJyK33d49ZWbjFBaIgU/edit#) The brief description of code changes (hopefully to aid with code review) can be be found in the following link: [CodeChanges](https://docs.google.com/document/d/18mqjhL9V1An-tNta7aVE13HkALRZ5GZ24AATA-Vqqf0/edit#) ## How was this patch tested? The test case PRs were submitted earlier using. [16337](#16337) [16759](#16759) [16841](#16841) [16915](#16915) [16798](#16798) [16712](#16712) [16710](#16710) [16760](#16760) [16802](#16802) Author: Dilip Biswal <dbiswal@us.ibm.com> Closes #16954 from dilipbiswal/SPARK-18874.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is 2nd batch of test case for IN/NOT IN subquery. In this PR, it has these test cases:
in-limit.sqlin-order-by.sqlnot-in-group-by.sqlThese are the queries and results from running on DB2.
in-limit DB2 version
in-order-by DB2 version
not-in-group-by DB2 version
output of in-limit.sql DB2
output of in-order-by.sql DB2
output of not-in-group-by.sql DB2
How was this patch tested?
This pr is adding new test cases.