[SPARK-19437] Rectify spark executor id in HeartbeatReceiverSuite.

[jinxing64]

What changes were proposed in this pull request?

The current code in HeartbeatReceiverSuite, executorId is set as below:

  private val executorId1 = "executor-1"
  private val executorId2 = "executor-2"

The executorId is sent to driver when register as below:

test("expire dead hosts should kill executors with replacement (SPARK-8119)")  {
  ...
  fakeSchedulerBackend.driverEndpoint.askSync[Boolean](
      RegisterExecutor(executorId1, dummyExecutorEndpointRef1, "1.2.3.4", 0, Map.empty))
  ...
}

Receiving RegisterExecutor in CoarseGrainedSchedulerBackend, the executorId will be compared with currentExecutorIdCounter as below:

case RegisterExecutor(executorId, executorRef, hostname, cores, logUrls)  =>
  if (executorDataMap.contains(executorId)) {
    executorRef.send(RegisterExecutorFailed("Duplicate executor ID: " + executorId))
    context.reply(true)
  } else {
  ...
  executorDataMap.put(executorId, data)
  if (currentExecutorIdCounter < executorId.toInt) {
    currentExecutorIdCounter = executorId.toInt
  }
  ...

executorId.toInt will cause NumberformatException.

This unit test can pass currently because of askWithRetry, when catching exception, RPC will call again, thus it will go if branch and return true.

To fix
Rectify executorId and replace askWithRetry with askSync, refer to #16690

How was this patch tested?

This fix is for unit test and no need to add another one.(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

[srowen]

CC @zsxwing

[SparkQA]

Test build #3553 has finished for PR 16779 at commit 06efcac.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[zsxwing]

@jinxing64 Good catch. Since you are touching this file, could you also replace other askWithRetry in this file with askSync?

[zsxwing]

LGTM pending tests

[jinxing64]

@zsxwing
Thanks a lot for reviewing this. Not sure why the test doesn't start automatically.

[zsxwing]

ok to test

[SparkQA]

Test build #72297 has finished for PR 16779 at commit a9bc3f4.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds no public classes.

[zsxwing]

Thanks! Merging to master.

[jinxing64]

Thanks a lot for reviewing this.