[SPARK-19599][SS]Clean up HDFSMetadataLog #16932
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsxwing
commented
Feb 14, 2017
| // So throw an exception to tell the user this is not a valid behavior. | ||
| throw new ConcurrentModificationException( | ||
| s"Multiple HDFSMetadataLog are using $path", e) | ||
| case e: FileNotFoundException => |
Member
Author
There was a problem hiding this comment.
Removed it because we always create a temp file so it won't happen.
|
Test build #72890 has finished for PR 16932 at commit
|
Member
Author
|
retest this please |
|
Test build #72899 has finished for PR 16932 at commit
|
Member
Author
|
retest this please |
|
Test build #72898 has finished for PR 16932 at commit
|
|
Test build #72906 has finished for PR 16932 at commit
|
zsxwing
changed the title
srowen
approved these changes
Feb 15, 2017
Contributor
|
LGTM! |
|
Test build #72954 has finished for PR 16932 at commit
|
Member
Author
|
Thanks! Merging to master. |
asfgit
pushed a commit
that referenced
this pull request
Feb 16, 2017
## What changes were proposed in this pull request? SPARK-19464 removed support for Hadoop 2.5 and earlier, so we can do some cleanup for HDFSMetadataLog. This PR includes the following changes: - ~~Remove the workaround codes for HADOOP-10622.~~ Unfortunately, there is another issue [HADOOP-14084](https://issues.apache.org/jira/browse/HADOOP-14084) that prevents us from removing the workaround codes. - Remove unnecessary `writer: (T, OutputStream) => Unit` and just call `serialize` directly. - Remove catching FileNotFoundException. ## How was this patch tested? Jenkins Author: Shixiong Zhu <shixiong@databricks.com> Closes #16932 from zsxwing/metadata-cleanup. (cherry picked from commit 21b4ba2) Signed-off-by: Shixiong Zhu <shixiong@databricks.com>
Member
Author
|
Since this change is minor and safe, I also cherry-picked to 2.1 to avoid merge conflicts in future. |
Member
|
The final code change doesn't assume Hadoop 2.6 right? |
Member
Author
Right. |
cmonkey
pushed a commit
to cmonkey/spark
that referenced
this pull request
Feb 16, 2017
## What changes were proposed in this pull request? SPARK-19464 removed support for Hadoop 2.5 and earlier, so we can do some cleanup for HDFSMetadataLog. This PR includes the following changes: - ~~Remove the workaround codes for HADOOP-10622.~~ Unfortunately, there is another issue [HADOOP-14084](https://issues.apache.org/jira/browse/HADOOP-14084) that prevents us from removing the workaround codes. - Remove unnecessary `writer: (T, OutputStream) => Unit` and just call `serialize` directly. - Remove catching FileNotFoundException. ## How was this patch tested? Jenkins Author: Shixiong Zhu <shixiong@databricks.com> Closes apache#16932 from zsxwing/metadata-cleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SPARK-19464 removed support for Hadoop 2.5 and earlier, so we can do some cleanup for HDFSMetadataLog.
This PR includes the following changes:
Remove the workaround codes for HADOOP-10622.Unfortunately, there is another issue HADOOP-14084 that prevents us from removing the workaround codes.writer: (T, OutputStream) => Unitand just callserializedirectly.How was this patch tested?
Jenkins