Skip to content

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Feb 15, 2017

What changes were proposed in this pull request?

A small update to #16925

  1. Rename SubstituteHints -> ResolveHints to be more consistent with rest of the rules.
  2. Added more documentation in the rule and be more defensive / future proof to skip views as well as CTEs.

How was this patch tested?

This pull request contains no real logic change and all behavior should be covered by existing tests.

@SparkQA
Copy link

SparkQA commented Feb 15, 2017

Test build #72933 has finished for PR 16939 at commit 4310807.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@hvanhovell
Copy link
Contributor

LGTM - merging to master. Thanks.

@asfgit asfgit closed this in 733c59e Feb 15, 2017
cmonkey pushed a commit to cmonkey/spark that referenced this pull request Feb 16, 2017
## What changes were proposed in this pull request?
A small update to apache#16925

1. Rename SubstituteHints -> ResolveHints to be more consistent with rest of the rules.
2. Added more documentation in the rule and be more defensive / future proof to skip views as well as CTEs.

## How was this patch tested?
This pull request contains no real logic change and all behavior should be covered by existing tests.

Author: Reynold Xin <rxin@databricks.com>

Closes apache#16939 from rxin/SPARK-16475.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants