[SPARK-19550][BUILD][WIP] Addendum: select Java 1.7 for scalac 2.10, still #16983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #73104 has finished for PR 16983 at commit
|
Member
Author
|
This change does avoid the error at #16871 (comment) when I run the same commands that the Jenkins job does When I undo it it fails again. When back online I'll check that the changed build runs to completion with SBT. |
Contributor
|
LGTM if the build finishes |
vanzin
approved these changes
Feb 18, 2017
Member
Author
|
Merged to master |
Yunni
pushed a commit
to Yunni/spark
that referenced
this pull request
Feb 27, 2017
…still ## What changes were proposed in this pull request? Go back to selecting source/target 1.7 for Scala 2.10 builds, because the SBT-based build for 2.10 won't work otherwise. ## How was this patch tested? Existing tests, but, we need to verify this vs what the SBT build would exactly run on Jenkins Author: Sean Owen <sowen@cloudera.com> Closes apache#16983 from srowen/SPARK-19550.3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Go back to selecting source/target 1.7 for Scala 2.10 builds, because the SBT-based build for 2.10 won't work otherwise.
How was this patch tested?
Existing tests, but, we need to verify this vs what the SBT build would exactly run on Jenkins