Skip to content

[SPARK-19679][ML] Destroy broadcasted object without blocking #17016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhengruifeng wants to merge 1 commit into from
Closed

[SPARK-19679][ML] Destroy broadcasted object without blocking #17016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mllib/src/main/scala/org/apache/spark/ml/tree/impl/GradientBoostedTrees.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ private[spark] object GradientBoostedTrees extends Logging {
(a, b) => treesIndices.map(idx => a(idx) + b(idx)))
.map(_ / dataCount)

broadcastTrees.destroy()
broadcastTrees.destroy(blocking = false)
evaluation.toArray
}

Expand Down
2 changes: 1 addition & 1 deletion mllib/src/main/scala/org/apache/spark/mllib/optimization/LBFGS.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ object LBFGS extends Logging {
val (gradientSum, lossSum) = data.treeAggregate((zeroSparseVector, 0.0))(seqOp, combOp)

// broadcasted model is not needed anymore
bcW.destroy()
bcW.destroy(blocking = false)

/**
* regVal is sum of weight squares if it's L2 updater;
Expand Down
2 changes: 1 addition & 1 deletion mllib/src/main/scala/org/apache/spark/mllib/tree/model/treeEnsembleModels.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ class GradientBoostedTreesModel @Since("1.2.0") (
(a, b) => treesIndices.map(idx => a(idx) + b(idx)))
.map(_ / dataCount)

broadcastTrees.destroy()
broadcastTrees.destroy(blocking = false)
evaluation.toArray
}

Expand Down