[SPARK-19724][SQL][WIP]create a managed table with an existed default location should throw an exception #17057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… location should throw an exception
windpiger
commented
Feb 24, 2017
| test("CTAS for managed data source table with a created default location throw an exception") { | ||
| withTable("t", "t1", "t2") { | ||
| val warehousePath = spark.sharedState.warehousePath.stripPrefix("file:") | ||
| val tFile = new File(warehousePath, "t") |
Contributor
Author
There was a problem hiding this comment.
there are lots of non-existent default location test cases, so here we just add existed default location test cases
windpiger
changed the title
|
Test build #73421 has finished for PR 17057 at commit
|
windpiger
changed the title
|
Test build #73420 has finished for PR 17057 at commit
|
windpiger
changed the title
|
Test build #73426 has finished for PR 17057 at commit
|
windpiger
changed the title
|
Test build #73428 has finished for PR 17057 at commit
|
|
Test build #73429 has finished for PR 17057 at commit
|
windpiger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This JIRA is a follow up work after SPARK-19583
As we discussed in that PR
The following DDL for a managed table with an existed default location should throw an exception:
Currently there are some situations which are not consist with above logic:
CREATE TABLE ... (PARTITIONED BY ...) succeed with an existed default location
situation: for both hive/datasource(with HiveExternalCatalog/InMemoryCatalog)
CREATE TABLE ... (PARTITIONED BY ...) AS SELECT ...
situation: hive table succeed with an existed default location
This PR is going to make above two situations consist with the logic that it should throw an exception
with an existed default location.
How was this patch tested?
unit test added