Skip to content

Conversation

@jinxing64
Copy link

@jinxing64 jinxing64 commented Mar 1, 2017

What changes were proposed in this pull request?

When check speculatable tasks in TaskSetManager, only scan runningTasksSet instead of scanning all taskInfos.

How was this patch tested?

Existing tests.

@jinxing64 jinxing64 changed the title [SPARK-19777] Scan runningTasksSet when check speculatable tasks in T… [SPARK-19777] Scan runningTasksSet when check speculatable tasks in TaskSetManager. Mar 1, 2017
@jinxing64
Copy link
Author

cc @kayousterhout @squito

@squito
Copy link
Contributor

squito commented Mar 1, 2017

lgtm

(btw, I just meant to update your old PR to mention the new jira in the title -- you didn't have to open a new pr. but this works too)

@jinxing64
Copy link
Author

@squito
Thanks a lot :)

@SparkQA
Copy link

SparkQA commented Mar 1, 2017

Test build #73649 has finished for PR 17111 at commit 819a5e8.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Mar 1, 2017

Test build #73667 has finished for PR 17111 at commit 6840ce1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kayousterhout
Copy link
Contributor

Thanks for fixing this! I've merged this.

@asfgit asfgit closed this in 51be633 Mar 2, 2017
@jinxing64
Copy link
Author

@kayousterhout
Thanks for merging.
(btw, I made some measurements for #16867 SPARK-16929, please take a look when you have time :) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants