-
Notifications
You must be signed in to change notification settings - Fork 29k
[Doc][Minor][SparkR] Update SparkR doc for names, columns and colnames #17115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@felixcheung I see lots of the SparkDataFrame methods use the following in examples: I'm not sure where this json file resides. Do you think it's better to use a more concrete data example? |
|
( @actuaryzhang , maybe we could make the PR title more meaningful to summerise the change just for a better shaped PR ) |
|
Yes please. The file doesn't exist. Its name suggests this is just an example path. |
|
Test build #73679 has finished for PR 17115 at commit
|
|
great thanks!
|
|
@HyukjinKwon Thanks. Updated title. |
|
@srowen @felixcheung I have seen lots of R package document the methods together in a single doc. This way, it's easier to see what methods are available. Also the examples for all methods can be documented together, sharing the same data set (so that we don't have to create one data set for each method). We can use the @describeIn tag to do this. Let me know if this is a good approach. |
|
Test build #73704 has finished for PR 17115 at commit
|
|
@actuaryzhang can you point me to an example you are thinking of? |
|
yeah, looking at |
|
this merged to master |
Update R doc:
colnames<-does allow the subset assignment, so the length ofvaluecan be less than the number of columns, e.g.,colnames(df)[1] <- "a".@felixcheung