[SPARK-20102] Fix nightly packaging and RC packaging scripts w/ two minor build fixes #17437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
JoshRosen
commented
Mar 26, 2017
| 'pyspark.ml', | ||
| 'pyspark.ml.linalg', | ||
| 'pyspark.ml.param', | ||
| 'pyspark.ml.stat', |
Contributor
Author
There was a problem hiding this comment.
@holdenk @viirya, quick question here: I see that this pyspark.ml.stat line was added in #16465. The problem with this line is that it seems to cause failures during python setup.py sdist packaging because that process searches for a non-existent pyspark/ml/stat file / directory.
Was this ml.stat just a typo?
Member
There was a problem hiding this comment.
I think it was. There is pyspark.mllib.stat but no pyspark.ml.stat. Seems it is mistakenly missing the non-parity between mllib and ml sub-modules.
JoshRosen
changed the title
JoshRosen
changed the title
|
Test build #75246 has finished for PR 17437 at commit
|
Contributor
Author
|
I'm going to merge this into master and branch-2.1 then will manually kick off the packaging jobs so that we can get back to publishing nightly package snapshots. |
asfgit
pushed a commit
that referenced
this pull request
Mar 27, 2017
…inor build fixes ## What changes were proposed in this pull request? The master snapshot publisher builds are currently broken due to two minor build issues: 1. For unknown reasons, the LFTP `mkdir -p` command began throwing errors when the remote directory already exists. This change of behavior might have been caused by configuration changes in the ASF's SFTP server, but I'm not entirely sure of that. To work around this problem, this patch updates the script to ignore errors from the `lftp mkdir -p` commands. 2. The PySpark `setup.py` file references a non-existent `pyspark.ml.stat` module, causing Python packaging to fail by complaining about a missing directory. The fix is to simply drop that line from the setup script. ## How was this patch tested? The LFTP fix was tested by manually running the failing commands on AMPLab Jenkins against the ASF SFTP server. The PySpark fix was tested locally. Author: Josh Rosen <joshrosen@databricks.com> Closes #17437 from JoshRosen/spark-20102. (cherry picked from commit 314cf51) Signed-off-by: Josh Rosen <joshrosen@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The master snapshot publisher builds are currently broken due to two minor build issues:
mkdir -pcommand began throwing errors when the remote directory already exists. This change of behavior might have been caused by configuration changes in the ASF's SFTP server, but I'm not entirely sure of that. To work around this problem, this patch updates the script to ignore errors from thelftp mkdir -pcommands.setup.pyfile references a non-existentpyspark.ml.statmodule, causing Python packaging to fail by complaining about a missing directory. The fix is to simply drop that line from the setup script.How was this patch tested?
The LFTP fix was tested by manually running the failing commands on AMPLab Jenkins against the ASF SFTP server. The PySpark fix was tested locally.