[SPARK-20358] [core] Executors failing stage on interrupted exception thrown by cancelled tasks #17659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #75861 has finished for PR 17659 at commit
|
Contributor
Author
|
Ping. |
Contributor
|
lgtm. Merging to master and branch-2.2. |
asfgit
pushed a commit
that referenced
this pull request
Apr 20, 2017
…thrown by cancelled tasks ## What changes were proposed in this pull request? This was a regression introduced by my earlier PR here: #17531 It turns out NonFatal() does not in fact catch InterruptedException. ## How was this patch tested? Extended cancellation unit test coverage. The first test fails before this patch. cc JoshRosen mridulm Author: Eric Liang <ekl@databricks.com> Closes #17659 from ericl/spark-20358. (cherry picked from commit b2ebadf) Signed-off-by: Yin Huai <yhuai@databricks.com>
jzhuge
pushed a commit
to jzhuge/spark
that referenced
this pull request
Aug 20, 2018
…thrown by cancelled tasks This was a regression introduced by my earlier PR here: apache#17531 It turns out NonFatal() does not in fact catch InterruptedException. Extended cancellation unit test coverage. The first test fails before this patch. cc JoshRosen mridulm Author: Eric Liang <ekl@databricks.com> Closes apache#17659 from ericl/spark-20358.
peter-toth
pushed a commit
to peter-toth/spark
that referenced
this pull request
Oct 6, 2018
…thrown by cancelled tasks ## What changes were proposed in this pull request? This was a regression introduced by my earlier PR here: apache#17531 It turns out NonFatal() does not in fact catch InterruptedException. ## How was this patch tested? Extended cancellation unit test coverage. The first test fails before this patch. cc JoshRosen mridulm Author: Eric Liang <ekl@databricks.com> Closes apache#17659 from ericl/spark-20358.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This was a regression introduced by my earlier PR here: #17531
It turns out NonFatal() does not in fact catch InterruptedException.
How was this patch tested?
Extended cancellation unit test coverage. The first test fails before this patch.
cc @JoshRosen @mridulm