Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@ case class InMemoryTableScanExec(
override def output: Seq[Attribute] = attributes

private def updateAttribute(expr: Expression): Expression = {
val attrMap = AttributeMap(relation.child.output.zip(output))
// attributes can be pruned so using relation's output.
// E.g., relation.output is [id, item] but this scan's output can be [item] only.
val attrMap = AttributeMap(relation.child.output.zip(relation.output))
expr.transform {
case attr: Attribute => attrMap.getOrElse(attr, attr)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -414,4 +414,19 @@ class InMemoryColumnarQuerySuite extends QueryTest with SharedSQLContext {
assert(partitionedAttrs.subsetOf(inMemoryScan.outputSet))
}
}

test("SPARK-20356: pruned InMemoryTableScanExec should have correct ordering and partitioning") {
withSQLConf("spark.sql.shuffle.partitions" -> "200") {
val df1 = Seq(("a", 1), ("b", 1), ("c", 2)).toDF("item", "group")
val df2 = Seq(("a", 1), ("b", 2), ("c", 3)).toDF("item", "id")
val df3 = df1.join(df2, Seq("item")).select($"id", $"group".as("item")).distinct()

df3.unpersist()
val agg_without_cache = df3.groupBy($"item").count()

df3.cache()
val agg_with_cache = df3.groupBy($"item").count()
checkAnswer(agg_without_cache, agg_with_cache)
}
}
}