[SPARK-20496][SS] Bug in KafkaWriter Looks at Unanalyzed Plans #17804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 28, 2017 07:50
Contributor
Author
|
cc @brkyvz this should be good to go. |
|
Test build #76271 has finished for PR 17804 at commit
|
|
Test build #76272 has finished for PR 17804 at commit
|
Contributor
|
@anabranch can you open this against branch-2.1 instead of master? |
Contributor
|
@hvanhovell We need this fix in master as well. It somehow works magically in master, but is broken for sure in 2.1 |
Contributor
Author
|
yeah it's broken in both, only visible in 1. Not sure if that needs to be in 2 PRs. |
brkyvz
approved these changes
Apr 28, 2017
Contributor
brkyvz
left a comment
brkyvz
left a comment
There was a problem hiding this comment.
minor nits, LGTM. Will merge pending tests + nit addressing
|
|
||
| import org.apache.spark.SparkException | ||
| import org.apache.spark.sql._ | ||
| import org.apache.spark.sql.catalyst.analysis.UnresolvedException |
| import org.apache.spark.sql.types.{BinaryType, DataType} | ||
|
|
||
| class KafkaSinkSuite extends StreamTest with SharedSQLContext { | ||
|
|
| .option("kafka.bootstrap.servers", testUtils.brokerAddress) | ||
| .option("topic", topic) | ||
| .save() | ||
|
|
| val topic = newTopic() | ||
| testUtils.createTopic(topic) | ||
|
|
||
| inputEvents.write |
Contributor
There was a problem hiding this comment.
nit: wrong indentation. + I would add a comment here that this would used to throw an UnresolvedException
| s"save mode overwrite not allowed for kafka")) | ||
| } | ||
|
|
||
| test("batch - enforce analyzed plans SPARK-20496") { |
Contributor
There was a problem hiding this comment.
nit: SPARK-20496: batch - enforce analyzed plans
Contributor
|
LGTM! |
|
Test build #76275 has finished for PR 17804 at commit
|
Contributor
|
merging to master, branch-2.2 and branch-2.1 |
asfgit
pushed a commit
that referenced
this pull request
Apr 28, 2017
## What changes were proposed in this pull request? We didn't enforce analyzed plans in Spark 2.1 when writing out to Kafka. ## How was this patch tested? New unit test. Please review http://spark.apache.org/contributing.html before opening a pull request. Author: Bill Chambers <bill@databricks.com> Closes #17804 from anabranch/SPARK-20496-2. (cherry picked from commit 733b81b) Signed-off-by: Burak Yavuz <brkyvz@gmail.com>
asfgit
pushed a commit
that referenced
this pull request
Apr 28, 2017
## What changes were proposed in this pull request? We didn't enforce analyzed plans in Spark 2.1 when writing out to Kafka. ## How was this patch tested? New unit test. Please review http://spark.apache.org/contributing.html before opening a pull request. Author: Bill Chambers <bill@databricks.com> Closes #17804 from anabranch/SPARK-20496-2. (cherry picked from commit 733b81b) Signed-off-by: Burak Yavuz <brkyvz@gmail.com>
jzhuge
pushed a commit
to jzhuge/spark
that referenced
this pull request
Aug 20, 2018
We didn't enforce analyzed plans in Spark 2.1 when writing out to Kafka. New unit test. Please review http://spark.apache.org/contributing.html before opening a pull request. Author: Bill Chambers <bill@databricks.com> Closes apache#17804 from anabranch/SPARK-20496-2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We didn't enforce analyzed plans in Spark 2.1 when writing out to Kafka.
How was this patch tested?
New unit test.
Please review http://spark.apache.org/contributing.html before opening a pull request.