Skip to content

Conversation

@marmbrus
Copy link
Contributor

@marmbrus marmbrus commented Aug 5, 2014

No description provided.

@SparkQA
Copy link

SparkQA commented Aug 5, 2014

QA tests have started for PR 1785. This patch merges cleanly.
View progress: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17939/consoleFull

@SparkQA
Copy link

SparkQA commented Aug 5, 2014

QA results for PR 1785:
- This patch PASSES unit tests.
- This patch merges cleanly
- This patch adds the following public classes (experimental):
trait TypeWidening {

For more information see test ouptut:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/17939/consoleFull

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to leave this in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its essentially free and could be useful to turn on if we ever have problems with this rule again.

@concretevitamin
Copy link
Contributor

A few minor comments otherwise LGTM!

@marmbrus
Copy link
Contributor Author

marmbrus commented Aug 5, 2014

Thanks for looking this over. Merged to master and 1.1

@asfgit asfgit closed this in 6e821e3 Aug 5, 2014
asfgit pushed a commit that referenced this pull request Aug 5, 2014
Author: Michael Armbrust <michael@databricks.com>

Closes #1785 from marmbrus/caseNull and squashes the following commits:

126006d [Michael Armbrust] better error message
2fe357f [Michael Armbrust] Fix coercion of CASE WHEN.

(cherry picked from commit 6e821e3)
Signed-off-by: Michael Armbrust <michael@databricks.com>
@marmbrus marmbrus deleted the caseNull branch August 27, 2014 20:43
xiliu82 pushed a commit to xiliu82/spark that referenced this pull request Sep 4, 2014
Author: Michael Armbrust <michael@databricks.com>

Closes apache#1785 from marmbrus/caseNull and squashes the following commits:

126006d [Michael Armbrust] better error message
2fe357f [Michael Armbrust] Fix coercion of CASE WHEN.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants