Skip to content

[SPARK-20608] allow standby namenodes in spark.yarn.access.namenodes(@deprecated) #17870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
charliechen211 wants to merge 1 commit into from
Closed

[SPARK-20608] allow standby namenodes in spark.yarn.access.namenodes(@deprecated) #17870

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 21 additions & 5 deletions yarn/src/main/scala/org/apache/spark/deploy/yarn/security/HDFSCredentialProvider.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ import scala.collection.JavaConverters._
import org.apache.hadoop.conf.Configuration
import org.apache.hadoop.fs.{FileSystem, Path}
import org.apache.hadoop.hdfs.security.token.delegation.DelegationTokenIdentifier
import org.apache.hadoop.ipc.RemoteException
import org.apache.hadoop.ipc.StandbyException
import org.apache.hadoop.mapred.Master
import org.apache.hadoop.security.Credentials

Expand All @@ -45,9 +47,16 @@ private[security] class HDFSCredentialProvider extends ServiceCredentialProvider
creds: Credentials): Option[Long] = {
// NameNode to access, used to get tokens from different FileSystems
nnsToAccess(hadoopConf, sparkConf).foreach { dst =>
val dstFs = dst.getFileSystem(hadoopConf)
logInfo("getting token for namenode: " + dst)
dstFs.addDelegationTokens(getTokenRenewer(hadoopConf), creds)
try {
val dstFs = dst.getFileSystem(hadoopConf)
logInfo("getting token for namenode: " + dst)
dstFs.addDelegationTokens(getTokenRenewer(hadoopConf), creds)
} catch {
case e: StandbyException =>
logWarning(s"Namenode ${dst} is in state standby", e)
case e: RemoteException =>
logWarning(s"Namenode ${dst} is in state standby", e)
}
}

// Get the token renewal interval if it is not set. It will only be called once.
Expand Down Expand Up @@ -75,8 +84,15 @@ private[security] class HDFSCredentialProvider extends ServiceCredentialProvider
sparkConf.get(PRINCIPAL).flatMap { renewer =>
val creds = new Credentials()
nnsToAccess(hadoopConf, sparkConf).foreach { dst =>
val dstFs = dst.getFileSystem(hadoopConf)
dstFs.addDelegationTokens(renewer, creds)
try {
val dstFs = dst.getFileSystem(hadoopConf)
dstFs.addDelegationTokens(renewer, creds)
} catch {
case e: StandbyException =>
logWarning(s"Namenode ${dst} is in state standby", e)
case e: RemoteException =>
logWarning(s"Namenode ${dst} is in state standby", e)
}
Copy link
Contributor

@steveloughran steveloughran May 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HADOOP-13372 implies that swift:// throws an UnknownHostException here; best to catch & log too, in case someone adds swift:// to the list of filesystems.

}
val hdfsToken = creds.getAllTokens.asScala
.find(_.getKind == DelegationTokenIdentifier.HDFS_DELEGATION_KIND)
Expand Down