-
Notifications
You must be signed in to change notification settings - Fork 29k
[SAPRK-20785][WEB-UI][SQL]Spark should provide jump links and add (count) in the SQL web ui. #18015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ucceeded|failed|unknown]
…remove redundant description.
…nning Queries (" + listener.getRunningExecutions.size + ")"
|
@SparkQA |
|
Test build #3761 has finished for PR 18015 at commit
|
|
Test build #3764 has finished for PR 18015 at commit
|
|
@srowen Help to merge to master and modify the status about https://issues.apache.org/jira/browse/SPARK-20785.Thanks. |
|
@srowen |
|
I don't think those links are worth the vertical space they chew up |
|
@srowen |
|
Yes I understand that, but I don't think the reasoning is as compelling here, and the style is a bit different. |
|
@srowen |
|
@srowen |
|
@srowen |
|
I don't support this but don't object of someone else merges |
|
@srowen |
|
@gatorsmile |
|
Hi @jerryshao, do you maybe have a preference? To me, I don't have a strong preference but I think I am okay with this. |
| {listener.getFailedExecutions.size} | ||
| </li> | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the indention here correct? This seems a little weird to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the style in the other files of the package org.apache.spark.sql.execution.ui
|
Jenkins, retest this please. |
|
Yes, I'm fine with it. @ajbozarth would you please take another look on this PR? Thanks. |
|
Test build #82064 has finished for PR 18015 at commit
|
|
This Jenkins error is not caused by this PR. |
|
retest this please |
|
And failed, who submitted the code in question. |
|
Test build #82072 has finished for PR 18015 at commit
|
|
Still LGTM |
|
@HyukjinKwon |
|
I think @jerryshao is an active committer who knows this one better than me. Since he is here, let me leave it to him. |
|
There's still left comment not addressed. |
|
Sorry, I accidentally deleted the code branch. I'm going to close this PR. I created a new PR #19346, which was modified and created based on the latest code. |
What changes were proposed in this pull request?
propose:
it provide links that jump to Running Queries,Completed Queries and Failed Queries.
it add (count) about Running Queries,Completed Queries and Failed Queries.
This is a small optimization in in the SQL web ui.
fix before:
fix after:
How was this patch tested?
manual tests
Please review http://spark.apache.org/contributing.html before opening a pull request.