Skip to content

Conversation

@yoonlee95
Copy link

@yoonlee95 yoonlee95 commented May 19, 2017

What changes were proposed in this pull request?

On status column of the table, I removed the condition that forced only the display value to take on values Active, Blacklisted and Dead.

Before the removal, values used for sort and filter for that particular column was True and False.

How was this patch tested?

Tested with Active, Blacklisted and Dead present as current status.

@yoonlee95 yoonlee95 changed the title [SPARK-20813][Web UI] Fixed web ui executor page search [SPARK-20813][Web UI] Fixed Web UI executor page tab search by status not working May 19, 2017
@ajbozarth
Copy link
Member

Nice catch, I'm not sure what @kishorvpatil 's original reason for blocking it from search like that was but this is good

@SparkQA
Copy link

SparkQA commented May 22, 2017

Test build #3748 has finished for PR 18036 at commit 2e0fdea.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request May 22, 2017
… not working

## What changes were proposed in this pull request?
On status column of the table, I removed the condition  that forced only the display value to take on values Active, Blacklisted and Dead.

Before the removal, values used for sort and filter for that particular column was True and False.
## How was this patch tested?

Tested with Active, Blacklisted and Dead present as current status.

Author: John Lee <jlee2@yahoo-inc.com>

Closes #18036 from yoonlee95/SPARK-20813.

(cherry picked from commit aea73be)
Signed-off-by: Sean Owen <sowen@cloudera.com>
@srowen
Copy link
Member

srowen commented May 22, 2017

Merged to master/2.2

@asfgit asfgit closed this in aea73be May 22, 2017
lycplus pushed a commit to lycplus/spark that referenced this pull request May 24, 2017
… not working

## What changes were proposed in this pull request?
On status column of the table, I removed the condition  that forced only the display value to take on values Active, Blacklisted and Dead.

Before the removal, values used for sort and filter for that particular column was True and False.
## How was this patch tested?

Tested with Active, Blacklisted and Dead present as current status.

Author: John Lee <jlee2@yahoo-inc.com>

Closes apache#18036 from yoonlee95/SPARK-20813.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants