[SPARK-20786][SQL][Backport-2.2]Improve ceil and floor handle the value which is not expected #18057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
ok to test |
|
Test build #77178 has finished for PR 18057 at commit
|
heary-cao
force-pushed
the
floor_ceil_branch_2.2
branch
from
5cdb501 to
1ecd0e2
Compare
|
Test build #77184 has finished for PR 18057 at commit
|
heary-cao
force-pushed
the
floor_ceil_branch_2.2
branch
from
1ecd0e2 to
eaf236a
Compare
heary-cao
commented
May 25, 2017
Contributor
Author
There was a problem hiding this comment.
The default type should be DoubleType
Contributor
Author
There was a problem hiding this comment.
The default type should be DoubleType
|
Test build #77327 has finished for PR 18057 at commit
|
heary-cao
force-pushed
the
floor_ceil_branch_2.2
branch
from
eaf236a to
4c68688
Compare
|
Test build #77333 has finished for PR 18057 at commit
|
ueshin
reviewed
May 25, 2017
|
|
||
| override def inputTypes: Seq[AbstractDataType] = | ||
| Seq(TypeCollection(DoubleType, DecimalType)) | ||
| Seq(TypeCollection(DoubleType, LongType, DecimalType)) |
Member
There was a problem hiding this comment.
I don't think we should modify the change from what we did at master when backporting as far as possible .
If you want to modify this, let's submit another pr to master first, and then backport it too.
Contributor
Author
|
the patch by #18103 merge together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is to backport #18016 to Spark branch-2.2
spark-sql>SELECT ceil(1234567890123456);
1234567890123456
spark-sql>SELECT ceil(12345678901234567);
12345678901234568
spark-sql>SELECT ceil(123456789012345678);
123456789012345680
when the length of the getText is greater than 16. long to double will be precision loss.
but mysql handle the value is ok.
mysql> SELECT ceil(1234567890123456);
+------------------------+
| ceil(1234567890123456) |
+------------------------+
| 1234567890123456 |
+------------------------+
1 row in set (0.00 sec)
mysql> SELECT ceil(12345678901234567);
+-------------------------+
| ceil(12345678901234567) |
+-------------------------+
| 12345678901234567 |
+-------------------------+
1 row in set (0.00 sec)
mysql> SELECT ceil(123456789012345678);
+--------------------------+
| ceil(123456789012345678) |
+--------------------------+
| 123456789012345678 |
+--------------------------+
1 row in set (0.00 sec)
How was this patch tested?
the unit test.