[SPARK-20867][SQL] Move hints from Statistics into HintInfo class #18087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #77301 has finished for PR 18087 at commit
|
Contributor
Author
gatorsmile
reviewed
May 24, 2017
| Statistics(sizeInBytes = sizeInBytes, isBroadcastable = isBroadcastable) | ||
| Statistics( | ||
| sizeInBytes = sizeInBytes, | ||
| hints = left.stats(conf).hints.resetForJoin()) |
Member
There was a problem hiding this comment.
We don't propagate isBroadcastable Hints in Intersect?
Contributor
Author
There was a problem hiding this comment.
It's actually no-op since Intersect is rewritten to a join always ..
Member
|
LGTM except one comment. |
asfgit
pushed a commit
that referenced
this pull request
May 24, 2017
## What changes were proposed in this pull request? This is a follow-up to SPARK-20857 to move the broadcast hint from Statistics into a new HintInfo class, so we can be more flexible in adding new hints in the future. ## How was this patch tested? Updated test cases to reflect the change. Author: Reynold Xin <rxin@databricks.com> Closes #18087 from rxin/SPARK-20867. (cherry picked from commit a647466) Signed-off-by: Xiao Li <gatorsmile@gmail.com>
Member
|
Thanks! Merging to master/2.2. |
peter-toth
pushed a commit
to peter-toth/spark
that referenced
this pull request
Oct 6, 2018
## What changes were proposed in this pull request? This is a follow-up to SPARK-20857 to move the broadcast hint from Statistics into a new HintInfo class, so we can be more flexible in adding new hints in the future. ## How was this patch tested? Updated test cases to reflect the change. Author: Reynold Xin <rxin@databricks.com> Closes apache#18087 from rxin/SPARK-20867. (cherry picked from commit a647466)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up to SPARK-20857 to move the broadcast hint from Statistics into a new HintInfo class, so we can be more flexible in adding new hints in the future.
How was this patch tested?
Updated test cases to reflect the change.