Skip to content

Conversation

@wangyum
Copy link
Member

@wangyum wangyum commented Jun 1, 2017

What changes were proposed in this pull request?

Built-in SQL Function UnaryMinus/UnaryPositive support string type, if it's string type, convert it to double type, after this PR:

spark-sql> select positive('-1.11'), negative('-1.11');
-1.11   1.11
spark-sql> 

How was this patch tested?

unit tests

@SparkQA
Copy link

SparkQA commented Jun 1, 2017

Test build #77635 has finished for PR 18173 at commit 5e7ed08.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 1, 2017

Test build #77638 has finished for PR 18173 at commit 3cc6f65.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 16, 2017

Test build #78173 has finished for PR 18173 at commit 7247282.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 16, 2017

Test build #78175 has finished for PR 18173 at commit 484a353.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

wangyum added 2 commits June 17, 2017 06:20
Conflicts:
	sql/core/src/test/resources/sql-tests/inputs/operators.sql
	sql/core/src/test/resources/sql-tests/results/operators.sql.out
@SparkQA
Copy link

SparkQA commented Jun 17, 2017

Test build #78195 has finished for PR 18173 at commit fd279b7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangyum
Copy link
Member Author

wangyum commented Jun 17, 2017

@gatorsmile It's same to ABS function support string type.

Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gatorsmile
Copy link
Member

Thanks! Merging to master.

@asfgit asfgit closed this in f913f15 Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants