[SPARK-20754][SQL][FOLLOWUP] Add Function Alias For MOD/POSITION. #18206
Conversation
|
Test build #77748 has finished for PR 18206 at commit
|
|
@wangyum Could you resolve the conflicts? Thanks! |
| select length(uuid()), (uuid() <> uuid()); | ||
|
|
||
| -- position | ||
| select position('bar', 'foobarbar'), position('bar', 'foobarbar', 5), position(null, 'foobarbar'), position('aaads', null); |
There was a problem hiding this comment.
The syntax of position is POSITION(substr IN str). It is different from LOCATE. You need to change the parser to support it.
There was a problem hiding this comment.
Please check what we did for remainder and the others in Parser supports.
| select floor(1234567890123456); | ||
|
|
||
| -- mod | ||
| select mod(7, 2), mod(7, 0), mod(0, 2), mod(7, null), mod(null, 2), mod(null, null); |
There was a problem hiding this comment.
Need to update the function description of Remainder . The example does not show this syntax.
…ition Conflicts: sql/core/src/test/resources/sql-tests/inputs/operators.sql sql/core/src/test/resources/sql-tests/results/operators.sql.out
|
Test build #77993 has finished for PR 18206 at commit
|
gatorsmile
left a comment
gatorsmile
left a comment
There was a problem hiding this comment.
Looks pretty good. Left a few minor comments.
| | SET | RESET | ||
| | VIEW | REPLACE | ||
| | IF | ||
| | POSITION |
There was a problem hiding this comment.
Add the keyword to TableIdentifierParserSuite
| | identifier #columnReference | ||
| | base=primaryExpression '.' fieldName=identifier #dereference | ||
| | '(' expression ')' #parenthesizedExpression | ||
| | POSITION '(' valueExpression IN valueExpression ')' #position |
There was a problem hiding this comment.
POSITION '(' substr=valueExpression IN str=valueExpression ')'
| IGNORE: 'IGNORE'; | ||
|
|
||
| IF: 'IF'; | ||
|
|
| 4 | ||
| > SELECT _FUNC_('bar', 'foobarbar', 5); | ||
| 7 | ||
| > SELECT POSITION('bar' in 'foobarbar'); |
| /** | ||
| * Create a Position expression. | ||
| */ | ||
| override def visitPosition(ctx: PositionContext): Expression = withOrigin(ctx) { |
There was a problem hiding this comment.
new StringLocate(expression(ctx.substr), expression(ctx.str))
|
Test build #78014 has finished for PR 18206 at commit
|
|
LGTM |
|
Thanks! Merging to master. |
## What changes were proposed in this pull request? apache#18106 Support TRUNC (number), We should also add function alias for `MOD `and `POSITION`. `POSITION(substr IN str) `is a synonym for `LOCATE(substr,str)`. same as MySQL: https://dev.mysql.com/doc/refman/5.7/en/string-functions.html#function_position ## How was this patch tested? unit tests Author: Yuming Wang <wgyumg@gmail.com> Closes apache#18206 from wangyum/SPARK-20754-mod&position.
3 participants
What changes were proposed in this pull request?
#18106 Support TRUNC (number), We should also add function alias for
MODandPOSITION.POSITION(substr IN str)is a synonym forLOCATE(substr,str). same as MySQL: https://dev.mysql.com/doc/refman/5.7/en/string-functions.html#function_positionHow was this patch tested?
unit tests