Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

What changes were proposed in this pull request?

After SPARK-20067, DESCRIBE and DESCRIBE EXTENDED shows the following result. This is incompatible with Spark 2.1.1. This PR removes the column header line in case of those commands.

MASTER and BRANCH-2.2

scala> sql("desc t").show(false)
+----------+---------+-------+
|col_name  |data_type|comment|
+----------+---------+-------+
|# col_name|data_type|comment|
|a         |int      |null   |
+----------+---------+-------+

SPARK 2.1.1 and this PR

scala> sql("desc t").show(false)
+--------+---------+-------+
|col_name|data_type|comment|
+--------+---------+-------+
|a       |int      |null   |
+--------+---------+-------+

How was this patch tested?

Pass the Jenkins with the updated test suites.

… compatible with previous Spark

After [SPARK-20067](https://issues.apache.org/jira/browse/SPARK-20067), `DESCRIBE` and `DESCRIBE EXTENDED` shows the following result. This is incompatible with Spark 2.1.1. This PR removes the column header line in case of those command.

**MASTER** and **BRANCH-2.2**
```scala
scala> sql("desc t").show(false)
+----------+---------+-------+
|col_name  |data_type|comment|
+----------+---------+-------+
|# col_name|data_type|comment|
|a         |int      |null   |
+----------+---------+-------+
```

**SPARK 2.1.1** and **this PR**
```scala
scala> sql("desc t").show(false)
+--------+---------+-------+
|col_name|data_type|comment|
+--------+---------+-------+
|a       |int      |null   |
+--------+---------+-------+
```

Pass the Jenkins with the updated test suites.
@SparkQA
Copy link

SparkQA commented Jun 9, 2017

Test build #77830 has finished for PR 18245 at commit a7ba238.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

asfgit pushed a commit that referenced this pull request Jun 9, 2017
…compatible with previous Spark

## What changes were proposed in this pull request?

After [SPARK-20067](https://issues.apache.org/jira/browse/SPARK-20067), `DESCRIBE` and `DESCRIBE EXTENDED` shows the following result. This is incompatible with Spark 2.1.1. This PR removes the column header line in case of those commands.

**MASTER** and **BRANCH-2.2**
```scala
scala> sql("desc t").show(false)
+----------+---------+-------+
|col_name  |data_type|comment|
+----------+---------+-------+
|# col_name|data_type|comment|
|a         |int      |null   |
+----------+---------+-------+
```

**SPARK 2.1.1** and **this PR**
```scala
scala> sql("desc t").show(false)
+--------+---------+-------+
|col_name|data_type|comment|
+--------+---------+-------+
|a       |int      |null   |
+--------+---------+-------+
```

## How was this patch tested?

Pass the Jenkins with the updated test suites.

Author: Dongjoon Hyun <dongjoon@apache.org>

Closes #18245 from dongjoon-hyun/SPARK-20954-BRANCH-2.2.
@cloud-fan
Copy link
Contributor

thanks, merging to 2.2!

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Jun 9, 2017

Thank you, @cloud-fan !

@cloud-fan
Copy link
Contributor

can you close this PR manually? thanks!

@dongjoon-hyun
Copy link
Member Author

Oh, sure!

@dongjoon-hyun dongjoon-hyun deleted the SPARK-20954-BRANCH-2.2 branch June 10, 2017 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants