Skip to content

Conversation

@wangyum
Copy link
Member

@wangyum wangyum commented Jun 16, 2017

What changes were proposed in this pull request?

The function char_length is shorthand for character_length function. Both Hive and Postgresql support character_length, This PR add support for character_length.

Ref:
https://cwiki.apache.org/confluence/display/Hive/LanguageManual+UDF#LanguageManualUDF-StringFunctions
https://www.postgresql.org/docs/current/static/functions-string.html

How was this patch tested?

unit tests

@SparkQA
Copy link

SparkQA commented Jun 16, 2017

Test build #78185 has finished for PR 18330 at commit 2fbf9e2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 17, 2017

Test build #78210 has finished for PR 18330 at commit 9bb23e5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@gatorsmile gatorsmile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gatorsmile
Copy link
Member

Thanks! Merging to master.

@asfgit asfgit closed this in ce49428 Jun 19, 2017
@wangyum wangyum deleted the SPARK-20749-character_length branch October 30, 2017 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants