[SPARK-21237][SQL] Invalidate stats once table data is changed #18449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzhfy
commented
Jun 28, 2017
| } | ||
| } | ||
|
|
||
| test("change stats after truncate command") { |
Contributor
Author
There was a problem hiding this comment.
I use "change" instead of "invalidate" in the test name, because in the near future when we support auto update, we can add check logic in the same test cases.
Contributor
Author
|
cc @cloud-fan |
|
Test build #78782 has finished for PR 18449 at commit
|
wzhfy
commented
Jun 29, 2017
|
|
||
| val stats2 = checkTableStats( | ||
| managedTable, hasSizeInBytes = true, expectedRowCounts = Some(4)) | ||
| assert(stats1 == stats2) |
Contributor
Author
There was a problem hiding this comment.
This check is no longer valid since stats is now removed after drop partition command.
Contributor
|
LGTM, merging to master! |
robert3005
pushed a commit
to palantir/spark
that referenced
this pull request
Jun 29, 2017
## What changes were proposed in this pull request? Invalidate spark's stats after data changing commands: - InsertIntoHadoopFsRelationCommand - InsertIntoHiveTable - LoadDataCommand - TruncateTableCommand - AlterTableSetLocationCommand - AlterTableDropPartitionCommand ## How was this patch tested? Added test cases. Author: wangzhenhua <wangzhenhua@huawei.com> Closes apache#18449 from wzhfy/removeStats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Invalidate spark's stats after data changing commands:
How was this patch tested?
Added test cases.