[SPARK-21370][SS] Add test for state reliability when one read-only state store aborts after read-write state store commits #18603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM! |
|
Test build #79543 has finished for PR 18603 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
During Streaming Aggregation, we have two StateStores per task, one used as read-only in
StateStoreRestoreExec, and one read-write used inStateStoreSaveExec.StateStore.abortwill be called for these StateStores if they haven't committed their results. We need to
make sure that
abortin read-only store after acommitin the read-write store doesn'taccidentally lead to the deletion of state.
This PR adds a test for this condition.
How was this patch tested?
This PR adds a test.