[SPARK-21415] Triage scapegoat warnings, part 1 #18635
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigDecimal double constructor Catching NPE Finalizer without super List.size is O Prefer Seq.empty Prefer Set.empty reverse.map instead of reverseMap Type shadowing Unnecessary if condition. Use .log1p Var could be val
|
Test build #79607 has finished for PR 18635 at commit
|
|
Test build #3843 has finished for PR 18635 at commit
|
Member
Author
|
Merged to master |
srowen
added a commit
to srowen/spark
that referenced
this pull request
Jul 18, 2017
## What changes were proposed in this pull request? Address scapegoat warnings for: - BigDecimal double constructor - Catching NPE - Finalizer without super - List.size is O(n) - Prefer Seq.empty - Prefer Set.empty - reverse.map instead of reverseMap - Type shadowing - Unnecessary if condition. - Use .log1p - Var could be val In some instances like Seq.empty, I avoided making the change even where valid in test code to keep the scope of the change smaller. Those issues are concerned with performance and it won't matter for tests. ## How was this patch tested? Existing tests Author: Sean Owen <sowen@cloudera.com> Closes apache#18635 from srowen/Scapegoat1.
cloud-fan
reviewed
Jul 18, 2017
| checkCompact(Decimal(BigDecimal(10.03)), false) | ||
| checkCompact(Decimal(BigDecimal(1e20)), false) | ||
| checkCompact(Decimal(BigDecimal("10.03")), false) | ||
| checkCompact(Decimal(BigDecimal("100000000000000000000")), false) |
Contributor
There was a problem hiding this comment.
might be better to write 1e20.toString
cloud-fan
reviewed
Jul 18, 2017
| // Return false as there is another writer. | ||
| false | ||
| } | ||
| // Return false as there is another writer. |
Contributor
There was a problem hiding this comment.
Is this comment still valid?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Address scapegoat warnings for:
In some instances like Seq.empty, I avoided making the change even where valid in test code to keep the scope of the change smaller. Those issues are concerned with performance and it won't matter for tests.
How was this patch tested?
Existing tests