Skip to content

[SPARK-21512][SQL][TEST] DatasetCacheSuite needs to execute unpersistent after executing peristent #18719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kiszk wants to merge 2 commits into from
Closed

[SPARK-21512][SQL][TEST] DatasetCacheSuite needs to execute unpersistent after executing peristent #18719

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e4438d
initial commit
kiszk Jul 23, 2017
e9d9a33
address review comment
kiszk Jul 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/DatasetCacheSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,11 @@ import org.apache.spark.storage.StorageLevel
class DatasetCacheSuite extends QueryTest with SharedSQLContext {
import testImplicits._

// Clear all persistent datasets after each test
override def afterEach(): Unit = {
spark.sharedState.cacheManager.clearCache()
Copy link
Member

@gatorsmile gatorsmile Jul 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

    try {
      // Clear all persistent datasets after each test
      spark.sharedState.cacheManager.clearCache()
    } finally {
      super.afterEach()
    }

Copy link
Contributor

@cloud-fan cloud-fan Jul 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, ideally we should always call super.afterEach, @kiszk can you send a follow-up PR? thx

Copy link
Member Author

@kiszk kiszk Jul 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I submitted #18721

}

test("get storage level") {
val ds1 = Seq("1", "2").toDS().as("a")
val ds2 = Seq(2, 3).toDS().as("b")
Expand Down