[SPARK-21498][Examples] quick start -> one py demo have some bug in code #18722

lizhaoch · 2017-07-24T07:27:35Z

I find a bug about 'quick start',and created a new issues,Sean Owen let
me to make a pull request, and I do

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Please review http://spark.apache.org/contributing.html before opening a pull request.

I find a bug about 'quick start',and created a new issues,Sean Owen let me to make a pull request, and I do

jerryshao · 2017-07-24T07:41:38Z

Can you please fix the PR title, also update the PR description to be more meaningful.

HyukjinKwon

LGTM

HyukjinKwon · 2017-07-24T13:32:44Z

docs/quick-start.md


 logFile = "YOUR_SPARK_HOME/README.md"  # Should be some file on your system
-spark = SparkSession.builder().appName(appName).master(master).getOrCreate()
+spark = SparkSession.builder.appName("SimpleApp").getOrCreate() 


Not a big deal at all but could we remove the trailing space at the end?

what about master?

I guess that should be fine.

it is described below and this looks doing the same thing with equivalent Scala / Java examples here.

HyukjinKwon

While we are here, would you mind fixing

424L - (e.g. `pip instal pyspark` -> (e.g., `pip install pyspark`)
424L - spark-submit -> `spark-submit`
427L - # Use spark-submit to run your application -> # Use Python interpeter to run your application for Python interpreter example

by apache#18722，Hyukjin Kwon pointed out some places to modify, I did it

lizhaoch · 2017-07-25T03:59:16Z

OK，I have done

by apache#18722,Hyukjin Kwon pointed out some places to modify,I did it.

HyukjinKwon · 2017-07-25T04:23:41Z

docs/quick-start.md

 Lines with a: 46, Lines with b: 23
 {% endhighlight %}

-


Let's revert removing a newline here. Sounds unrelated.

so many new lines , i did again

HyukjinKwon · 2017-07-25T04:24:26Z

docs/quick-start.md


 {% highlight bash %}
-# Use spark-submit to run your application
+# Use the Python Interpreter to run your application


I don't think we should capitalise "interpreter".

HyukjinKwon · 2017-07-25T04:24:57Z

docs/quick-start.md

 {% endhighlight %}

-If you have PySpark pip installed into your enviroment (e.g. `pip instal pyspark` you can run your application with the regular Python interpeter or use the provided spark-submit as you prefer.
+If you have PySpark pip installed into your enviroment (e.g., `pip instal pyspark` you can run your application with the regular Python Interpreter or use the provided 'spark-submit' as you prefer.


(e.g., `pip instal pyspark` -> (e.g., `pip install pyspark`)

as Gyukjin Kwon says,lost a 'l'

SparkQA · 2017-07-25T07:40:05Z

Test build #3849 has finished for PR 18722 at commit 77142b5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

HyukjinKwon · 2017-07-25T07:42:51Z

docs/quick-start.md

 {% endhighlight %}

-If you have PySpark pip installed into your enviroment (e.g. `pip instal pyspark` you can run your application with the regular Python interpeter or use the provided spark-submit as you prefer.
+If you have PySpark pip installed into your enviroment (e.g., `pip install pyspark` you can run your application with the regular Python Interpreter or use the provided 'spark-submit' as you prefer.


(e.g., `pip install pyspark` -> (e.g., `pip install pyspark`)

HyukjinKwon · 2017-07-25T07:43:25Z

docs/quick-start.md


 {% highlight bash %}
-# Use spark-submit to run your application
+# Use the Python Interpreter to run your application


Interpreter -> interpeter. I think it is Python interpreter.

HyukjinKwon · 2017-07-25T07:57:32Z

@lizhaoch, Could you double check #18722 (review)? I am repeating the same comments.

lizhaoch

perfect thks Hyukjin Kwon

by Hyukjin Kwon ，we check three places， and fix all

lizhaoch

I think is ok now ,thks Hyukjin Kwon

lizhaoch

comment again

HyukjinKwon · 2017-07-25T08:42:33Z

docs/quick-start.md

 {% endhighlight %}

-If you have PySpark pip installed into your enviroment (e.g. `pip instal pyspark` you can run your application with the regular Python interpeter or use the provided spark-submit as you prefer.
+If you have PySpark pip installed into your enviroment (e.g., `pip install pyspark` you can run your application with the regular Python interpreter or use the provided 'spark-submit' as you prefer.


others look good but for the last one ...

pip install pyspark` -> pip install pyspark`) (missing closing parenthesis).

submit again ，you are so careful,so good

that lookls ok

HyukjinKwon · 2017-07-25T09:01:02Z

docs/quick-start.md

 {% endhighlight %}

-If you have PySpark pip installed into your enviroment (e.g., `pip install pyspark` you can run your application with the regular Python interpreter or use the provided 'spark-submit' as you prefer.
+If you have PySpark pip installed into your enviroment (e.g., `pip install pyspark`), you can run your application with the regular Python Interpreter or use the provided 'spark-submit' as you prefer.


interpreter was fine ...

OMG OMG OMG .......

HyukjinKwon · 2017-07-25T09:27:29Z

LGTM

SparkQA · 2017-07-25T09:47:08Z

Test build #3851 has finished for PR 18722 at commit a31cbd8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

lizhaoch

ok

JIRA-SPARK-21498-quick start -> one py demo have some bug in code

a928de1

I find a bug about 'quick start',and created a new issues,Sean Owen let me to make a pull request, and I do

lizhaoch changed the title ~~JIRA-SPARK-21498-quick start -> one py demo have some bug in code~~ [SPARK-21498]-quick start -> one py demo have some bug in code Jul 24, 2017

lizhaoch changed the title ~~[SPARK-21498]-quick start -> one py demo have some bug in code~~ [SPARK-21498][Examples]quick start -> one py demo have some bug in code Jul 24, 2017

lizhaoch changed the title ~~[SPARK-21498][Examples]quick start -> one py demo have some bug in code~~ [SPARK-21498][Examples] quick start -> one py demo have some bug in code Jul 24, 2017

HyukjinKwon approved these changes Jul 24, 2017

View reviewed changes

HyukjinKwon reviewed Jul 25, 2017

View reviewed changes

Modified some places that Hyukjin Kwon pointed out

d7b6cb8

by apache#18722，Hyukjin Kwon pointed out some places to modify, I did it

lizhaoch added a commit to lizhaoch/spark that referenced this pull request Jul 25, 2017

Modified some places that Hyukjin Kwon pointed out

6d395f0

by apache#18722,Hyukjin Kwon pointed out some places to modify,I did it.

HyukjinKwon reviewed Jul 25, 2017

View reviewed changes

change on word

77142b5

as Gyukjin Kwon says,lost a 'l'

srowen approved these changes Jul 25, 2017

View reviewed changes

HyukjinKwon approved these changes Jul 25, 2017

View reviewed changes

lizhaoch commented Jul 25, 2017

View reviewed changes

that's should ok ..

e0fe00f

by Hyukjin Kwon ，we check three places， and fix all

lizhaoch commented Jul 25, 2017

View reviewed changes

HyukjinKwon reviewed Jul 25, 2017

View reviewed changes

that lookls ok

3a94272

that lookls ok

HyukjinKwon reviewed Jul 25, 2017

View reviewed changes

OMG OMG OMG

a31cbd8

OMG OMG OMG .......

lizhaoch commented Jul 25, 2017

View reviewed changes

asfgit closed this in 996a809 Jul 25, 2017

[SPARK-21498][Examples] quick start -> one py demo have some bug in code #18722

[SPARK-21498][Examples] quick start -> one py demo have some bug in code #18722

Uh oh!

Conversation

lizhaoch commented Jul 24, 2017

What changes were proposed in this pull request?

How was this patch tested?

Uh oh!

jerryshao commented Jul 24, 2017

Uh oh!

HyukjinKwon left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HyukjinKwon left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lizhaoch commented Jul 25, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HyukjinKwon Jul 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Jul 25, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HyukjinKwon commented Jul 25, 2017

Uh oh!

lizhaoch left a comment

Choose a reason for hiding this comment

Uh oh!

lizhaoch left a comment

Choose a reason for hiding this comment

Uh oh!

lizhaoch left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HyukjinKwon commented Jul 25, 2017

Uh oh!

SparkQA commented Jul 25, 2017

Uh oh!

lizhaoch left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

HyukjinKwon left a comment •

edited

Loading

HyukjinKwon Jul 25, 2017 •

edited

Loading