Skip to content

Conversation

@gczsjdy
Copy link

@gczsjdy gczsjdy commented Jul 28, 2017

What changes were proposed in this pull request?

The format of none should be consistent with other compression codec(`snappy`, `lz4`) as `none`.

How was this patch tested?

This is a typo.

@gczsjdy gczsjdy changed the title Fix typo in DataframeWriter doc [SQL] Fix typo in DataframeWriter doc Jul 28, 2017
@HyukjinKwon
Copy link
Member

Would you mind checking other typos in this file or module too? It'd be nicer if we fix them in batch,

@gczsjdy
Copy link
Author

gczsjdy commented Jul 28, 2017

@HyukjinKwon I can try to find other typos. But actually it's hard to find it until you use a certain API.

@HyukjinKwon
Copy link
Member

That's fine. I don't expect a perfect typo hunting but just think it's nicer to check around while we are here.

@gczsjdy
Copy link
Author

gczsjdy commented Jul 28, 2017

@HyukjinKwon You are right. I will do my best. : )

@srowen
Copy link
Member

srowen commented Jul 30, 2017

@HyukjinKwon I think you can just go ahead with this as a test run merge

@HyukjinKwon
Copy link
Member

Sure, will try.

@HyukjinKwon
Copy link
Member

ok to test

@HyukjinKwon
Copy link
Member

@srowen, I guess I need some manual steps to be added correctly as the admin in Jenkins IIRC. I sent a email to Josh yesterday and will handle this soon. Could you trigger the test here? Just want to be safe for the first try.

@SparkQA
Copy link

SparkQA commented Jul 30, 2017

Test build #3864 has finished for PR 18758 at commit 83530de.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@asfgit asfgit closed this in 51f99fb Jul 30, 2017
@HyukjinKwon
Copy link
Member

Thanks, I merged this into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants