[SPARK-22140] Add TPCDSQuerySuite #19361
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Test build #82227 has finished for PR 19361 at commit
|
Member
Author
|
cc @liancheng |
dongjoon-hyun
approved these changes
Sep 27, 2017
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. It's great to have this.
sameeragarwal
approved these changes
Sep 27, 2017
Member
sameeragarwal
left a comment
sameeragarwal
left a comment
There was a problem hiding this comment.
LGTM, thanks! Verified that the new test suite takes an additional 49s which seems like a reasonable trade-off to catch any compile time regressions in TPC-DS.
asfgit
pushed a commit
that referenced
this pull request
Sep 28, 2017
## What changes were proposed in this pull request? Now, we are not running TPC-DS queries as regular test cases. Thus, we need to add a test suite using empty tables for ensuring the new code changes will not break them. For example, optimizer/analyzer batches should not exceed the max iteration. ## How was this patch tested? N/A Author: gatorsmile <gatorsmile@gmail.com> Closes #19361 from gatorsmile/tpcdsQuerySuite. (cherry picked from commit 9244957) Signed-off-by: gatorsmile <gatorsmile@gmail.com>
Member
Author
|
Thanks! Merged to master/2.2 |
liancheng
reviewed
Sep 28, 2017
| classLoader = Thread.currentThread().getContextClassLoader) | ||
| test(name) { | ||
| withSQLConf(SQLConf.CROSS_JOINS_ENABLED.key -> "true") { | ||
| sql(queryString).collect() |
Contributor
There was a problem hiding this comment.
(Sorry for the late review.)
If the purpose of this test suite were testing the query planner, we can avoid running an end-to-end SQL job by replacing this line with:
sql(queryString).queryExecution.executedPlan
Also, please add comments to describe:
- The purpose of this test suite.
- How and why this line may fail (the analyzer and the optimizer may throw an exception if any rule batch reaches the max iteration limit).
We might also want to assert that the spark.testing Java property is indeed set here. Otherwise, this test suite catches nothing.
MatthewRBruce
pushed a commit
to Shopify/spark
that referenced
this pull request
Jul 31, 2018
## What changes were proposed in this pull request? Now, we are not running TPC-DS queries as regular test cases. Thus, we need to add a test suite using empty tables for ensuring the new code changes will not break them. For example, optimizer/analyzer batches should not exceed the max iteration. ## How was this patch tested? N/A Author: gatorsmile <gatorsmile@gmail.com> Closes apache#19361 from gatorsmile/tpcdsQuerySuite. (cherry picked from commit 9244957) Signed-off-by: gatorsmile <gatorsmile@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Now, we are not running TPC-DS queries as regular test cases. Thus, we need to add a test suite using empty tables for ensuring the new code changes will not break them. For example, optimizer/analyzer batches should not exceed the max iteration.
How was this patch tested?
N/A