-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-21840][core] Add trait that allows conf to be directly set in application. #19519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
55 changes: 55 additions & 0 deletions
55
core/src/main/scala/org/apache/spark/deploy/SparkApplication.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.deploy | ||
|
|
||
| import java.lang.reflect.Modifier | ||
|
|
||
| import org.apache.spark.SparkConf | ||
|
|
||
| /** | ||
| * Entry point for a Spark application. Implementations must provide a no-argument constructor. | ||
| */ | ||
| private[spark] trait SparkApplication { | ||
|
|
||
| def start(args: Array[String], conf: SparkConf): Unit | ||
|
|
||
| } | ||
|
|
||
| /** | ||
| * Implementation of SparkApplication that wraps a standard Java class with a "main" method. | ||
| * | ||
| * Configuration is propagated to the application via system properties, so running multiple | ||
| * of these in the same JVM may lead to undefined behavior due to configuration leaks. | ||
| */ | ||
| private[deploy] class JavaMainApplication(klass: Class[_]) extends SparkApplication { | ||
|
|
||
| override def start(args: Array[String], conf: SparkConf): Unit = { | ||
| val mainMethod = klass.getMethod("main", new Array[String](0).getClass) | ||
| if (!Modifier.isStatic(mainMethod.getModifiers)) { | ||
| throw new IllegalStateException("The main method in the given main class must be static") | ||
| } | ||
|
|
||
| val sysProps = conf.getAll.toMap | ||
| sysProps.foreach { case (k, v) => | ||
| sys.props(k) = v | ||
| } | ||
|
|
||
| mainMethod.invoke(null, args) | ||
| } | ||
|
|
||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vanzin , do we need to remove all the system properties after
mainMethodis finished?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's dangerous, because you don't know what the user code is doing. What if it spawns a thread and that separate thread creates the
SparkContext? Then you may be clearing system properties before the user app had the chance to read them.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But based on your comment "allow multiple applications to be started in the same JVM", will this system properties contaminate follow-up applications? Sorry if I misunderstood your scenario.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, and there's not much we can do in that case. The main use case will be to make cluster mode applications do the right thing first, and warn about starting in-process client mode applications through the launcher API.
If you have a better solution I'm all ears.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, thanks for explanation. I cannot figure out a solution which doesn't break the current semantics of
SparkConf, this might be the only choice.