[SPARK-22322][CORE] Update FutureAction for compatibility with Scala 2.12 Future #19561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpatbility, while retaining 2.11 comptability
srowen
commented
Oct 23, 2017
| */ | ||
| private[spark] object FutureAction { | ||
|
|
||
| private val transformTryMethod = |
Member
Author
There was a problem hiding this comment.
Having to access this by reflection is a little annoying but keeping 2.11 + 2.12 compatibility in one source file is nice, and doesn't entail much of any runtime overhead
| <id>scala-2.12</id> | ||
| <properties> | ||
| <scala.version>2.12.3</scala.version> | ||
| <scala.version>2.12.4</scala.version> |
Member
Author
There was a problem hiding this comment.
This update picks up a fix for another scalac bug that also prevents the 2.12 build from working, but, has no effect on 2.11
| } | ||
| } | ||
| AwaitTerminationTester.test(expectedBehavior, awaitTermFunc) | ||
| AwaitTerminationTester.test(expectedBehavior, () => awaitTermFunc()) |
Member
Author
There was a problem hiding this comment.
The rest here are just 2.12 warning cleanups by the by
| // and then filled in with a real implementation in the two subclasses below. The no-op exists | ||
| // here so that those implementations can declare "override", necessary in 2.12, while working | ||
| // in 2.11, where the method doesn't exist in the superclass. | ||
| // After 2.11 support goes away, remove these two: |
Member
Author
There was a problem hiding this comment.
In case it wasn't clear, this change ought to have no effect at all in 2.11
|
Test build #82991 has finished for PR 19561 at commit
|
Member
Author
|
Merged to master |
srowen
added a commit
to srowen/spark
that referenced
this pull request
Oct 25, 2017
…2.12 Future ## What changes were proposed in this pull request? Scala 2.12's `Future` defines two new methods to implement, `transform` and `transformWith`. These can be implemented naturally in Spark's `FutureAction` extension and subclasses, but, only in terms of the new methods that don't exist in Scala 2.11. To support both at the same time, reflection is used to implement these. ## How was this patch tested? Existing tests. Author: Sean Owen <sowen@cloudera.com> Closes apache#19561 from srowen/SPARK-22322.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Scala 2.12's
Futuredefines two new methods to implement,transformandtransformWith. These can be implemented naturally in Spark'sFutureActionextension and subclasses, but, only in terms of the new methods that don't exist in Scala 2.11. To support both at the same time, reflection is used to implement these.How was this patch tested?
Existing tests.