[SPARK-21912][SQL][FOLLOW-UP] ORC/Parquet table should not create invalid column names #19562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alid column names
|
Test build #82996 has finished for PR 19562 at commit
|
Member
Author
|
Thank you for review and approval, @gatorsmile ! |
Member
|
Thanks! Merged to master. |
Member
Author
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
During SPARK-21912, we skipped testing 'ADD COLUMNS' on ORC tables due to ORC limitation. Since SPARK-21929 is resolved now, we can test both
ORCandPARQUETcompletely.How was this patch tested?
Pass the updated test case.