[SPARK-22348][SQL] The table cache providing ColumnarBatch should also do partition batch pruning #19569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Good catch, thank you. Would it be possible to add a test case for pruning with table cache? |
Member
Author
|
@kiszk Thanks. I've roughly checked existing tests. Seems that there are no related ones for pruning the table cache. Let me see if I can add one. |
CodingCat
reviewed
Oct 25, 2017
| // Using these variables here to avoid serialization of entire objects (if referenced directly) | ||
| // within the map Partitions closure. | ||
| val relOutput: AttributeSeq = relation.output | ||
| val buffers = filteredCachedBatches() |
Contributor
There was a problem hiding this comment.
this seems to be a leftover of copy-paste
Member
Author
|
also cc @cloud-fan for review. |
|
Test build #83027 has finished for PR 19569 at commit
|
Contributor
|
good catch! merging to master, thanks! |
|
Test build #83031 has finished for PR 19569 at commit
|
|
Test build #83032 has finished for PR 19569 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We enable table cache
InMemoryTableScanExecto provideColumnarBatchnow. But the cached batches are retrieved without pruning. In this case, we still need to do partition batch pruning.How was this patch tested?
Existing tests.