Skip to content

[SPARK-22349]In on-heap mode, when allocating memory from pool,we should fill memory with MEMORY_DEBUG_FILL_CLEAN_VALUE #19572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
10110346 wants to merge 1 commit into from
Closed

[SPARK-22349]In on-heap mode, when allocating memory from pool,we should fill memory with MEMORY_DEBUG_FILL_CLEAN_VALUE #19572

10110346 wants to merge 1 commit into from

Conversation

@10110346
Copy link
Contributor

@10110346 10110346 commented Oct 25, 2017

What changes were proposed in this pull request?

In on-heap mode, when allocating memory from pool,we should fill memory with MEMORY_DEBUG_FILL_CLEAN_VALUE

How was this patch tested?

added unit tests

@10110346
Copy link
Contributor Author

10110346 commented Oct 25, 2017

cc @sameeragarwal @ericl

@SparkQA
Copy link

SparkQA commented Oct 25, 2017

Test build #83035 has finished for PR 19572 at commit 95ae9c3.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@10110346
Copy link
Contributor Author

10110346 commented Oct 25, 2017

retest this please

@kiszk
Copy link
Member

kiszk commented Oct 25, 2017

LGTM

@SparkQA
Copy link

SparkQA commented Oct 25, 2017

Test build #83036 has finished for PR 19572 at commit 95ae9c3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

jiangxb1987
jiangxb1987 approved these changes Oct 25, 2017
View reviewed changes
Copy link
Contributor

@jiangxb1987 jiangxb1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, also cc @cloud-fan

sameeragarwal
sameeragarwal approved these changes Oct 25, 2017
View reviewed changes
Copy link
Member

@sameeragarwal sameeragarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging in master. Thanks!

@asfgit asfgit closed this in 3d43a9f Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jiangxb1987 jiangxb1987 jiangxb1987 approved these changes

+1 more reviewer

@sameeragarwal sameeragarwal sameeragarwal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@10110346 @SparkQA @kiszk @sameeragarwal @jiangxb1987