[TRIVIAL] [SQL] Code cleaning in ResolveReferences #19585
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
jiangxb1987
approved these changes
Oct 27, 2017
Contributor
jiangxb1987
left a comment
jiangxb1987
left a comment
There was a problem hiding this comment.
LGTM pending jenkins
|
Test build #83109 has finished for PR 19585 at commit
|
Member
Author
|
retest this please |
|
Test build #83115 has finished for PR 19585 at commit
|
Member
Author
|
Thanks! Merged to master. |
cloud-fan
reviewed
Oct 27, 2017
|
|
||
| case q: LogicalPlan => | ||
| logTrace(s"Attempting to resolve ${q.simpleString}") | ||
| q.transformExpressionsUp { |
Contributor
There was a problem hiding this comment.
can you provide more context here? The previous code resolve reference bottom-up, so that we can resolve a.b.c.d with one round. The new code changes to top-down, why?
This was referenced Mar 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is to clean the related codes majorly based on the today's code review on #19559
How was this patch tested?
N/A