Skip to content

Conversation

@ueshin
Copy link
Member

@ueshin ueshin commented Nov 9, 2017

What changes were proposed in this pull request?

This is a follow-up of #19646 for branch-2.2.
The original pr breaks branch-2.2 because the cherry-picked patch doesn't include some code which exists in master.

How was this patch tested?

Existing tests.

@SparkQA
Copy link

SparkQA commented Nov 9, 2017

Test build #83628 has finished for PR 19704 at commit dfdb5fe.

  • This patch fails Python style tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@BryanCutler
Copy link
Member

LGTM, thanks @ueshin !

@SparkQA
Copy link

SparkQA commented Nov 9, 2017

Test build #83630 has finished for PR 19704 at commit b79885a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

I think we can merge this first to branch-2.2, and then re-run the test in 19701 ..

@ueshin
Copy link
Member Author

ueshin commented Nov 9, 2017

Thanks for reviewing! merging to branch-2.2.

asfgit pushed a commit that referenced this pull request Nov 9, 2017
…rom pandas.DataFrame with timestamp

## What changes were proposed in this pull request?

This is a follow-up of #19646 for branch-2.2.
The original pr breaks branch-2.2 because the cherry-picked patch doesn't include some code which exists in master.

## How was this patch tested?

Existing tests.

Author: Takuya UESHIN <ueshin@databricks.com>

Closes #19704 from ueshin/issues/SPARK-22417_2.2/fup1.
@ueshin ueshin closed this Nov 9, 2017
@dongjoon-hyun
Copy link
Member

Thank you, @ueshin !

MatthewRBruce pushed a commit to Shopify/spark that referenced this pull request Jul 31, 2018
…rom pandas.DataFrame with timestamp

## What changes were proposed in this pull request?

This is a follow-up of apache#19646 for branch-2.2.
The original pr breaks branch-2.2 because the cherry-picked patch doesn't include some code which exists in master.

## How was this patch tested?

Existing tests.

Author: Takuya UESHIN <ueshin@databricks.com>

Closes apache#19704 from ueshin/issues/SPARK-22417_2.2/fup1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants