[SPARK-22815] [SQL] Keep PromotePrecision in Optimized Plans #20000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #85003 has finished for PR 20000 at commit
|
|
cc @cloud-fan |
|
Test build #85014 has finished for PR 20000 at commit
|
|
retest this please |
|
Test build #85016 has finished for PR 20000 at commit
|
|
cc @cloud-fan |
|
Test build #85025 has finished for PR 20000 at commit
|
kiszk
reviewed
Dec 17, 2017
| @@ -20,7 +20,10 @@ package org.apache.spark.sql.catalyst.analysis | |||
| import scala.util.control.NonFatal | |||
|
|
|||
| import org.apache.spark.internal.Logging | |||
| import org.apache.spark.sql.catalyst.expressions.{Add, AttributeReference, AttributeSet, Cast, CheckOverflow, Expression, ExpressionSet, GreaterThan, GreaterThanOrEqual, LessThan, LessThanOrEqual, Literal, Multiply, PreciseTimestampConversion, PredicateHelper, Subtract, TimeAdd, TimeSub, UnaryMinus} | |||
| import org.apache.spark.sql.catalyst.expressions.{Add, AttributeReference, AttributeSet, Cast, CheckOverflow, Expression} | |||
| import org.apache.spark.sql.catalyst.expressions.{ExpressionSet, GreaterThan, GreaterThanOrEqual, LessThan, LessThanOrEqual} | |||
There was a problem hiding this comment.
maybe just import org.apache.spark.sql.catalyst.expressions._ ?
There was a problem hiding this comment.
Sorry. This splits long one line into two lines.
@cloud-fan's suggestion looks good to make them simple
|
Test build #85082 has finished for PR 20000 at commit
|
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We could get incorrect results by running DecimalPrecision twice. This PR resolves the original found in #15048 and #14797. After this PR, it becomes easier to change it back using
childreninstead of usinginnerChildren.How was this patch tested?
The existing test.