[SPARK-22821][TEST] Basic tests for WidenSetOperationTypes, BooleanEquality, StackCoercion and Division #20006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #85039 has finished for PR 20006 at commit
|
gatorsmile
reviewed
Dec 18, 2017
| SELECT true = cast('1' as binary) FROM t; | ||
| SELECT true = cast('1' as boolean) FROM t; | ||
| SELECT true = cast('2017-12-11 09:30:00.0' as timestamp) FROM t; | ||
| SELECT true = cast('2017-12-11 09:30:00' as date) FROM t; |
There was a problem hiding this comment.
Also please add the cases for false = 0
|
Test build #85052 has finished for PR 20006 at commit
|
gatorsmile
reviewed
Dec 19, 2017
| SELECT true = cast('1' as binary) FROM t; | ||
| SELECT true = cast(1 as boolean) FROM t; | ||
| SELECT true = cast('2017-12-11 09:30:00.0' as timestamp) FROM t; | ||
| SELECT true = cast('2017-12-11 09:30:00' as date) FROM t; |
There was a problem hiding this comment.
Could we just use one side?
For example, let us get rid of true = cast(1 as tinyint) and keep cast(1 as tinyint) = true?
There was a problem hiding this comment.
I think we should keep both, we have some below usage:
gatorsmile
reviewed
Dec 19, 2017
| SELECT cast(1 as string) / cast('2017-12-11 09:30:00.0' as timestamp) FROM t; | ||
| SELECT cast(1 as string) / cast('2017-12-11 09:30:00' as date) FROM t; | ||
|
|
||
| SELECT cast(1 as string) / cast(1 as tinyint) FROM t; |
gatorsmile
reviewed
Dec 19, 2017
|
|
||
| CREATE TEMPORARY VIEW t AS SELECT 1; | ||
|
|
||
| SELECT stack(cast(1 as tinyint), cast(1 as tinyint), null) FROM t; |
gatorsmile
reviewed
Dec 19, 2017
| SELECT cast('2017-12-12 09:30:00' as date) FROM t UNION SELECT cast('2017-12-11 09:30:00.0' as timestamp) FROM t; | ||
| SELECT cast('2017-12-12 09:30:00' as date) FROM t UNION SELECT cast('2017-12-11 09:30:00' as date) FROM t; | ||
|
|
||
| -- EXCEPT |
There was a problem hiding this comment.
We do not need EXCEPT and INTERSECT
|
Test build #85103 has finished for PR 20006 at commit
|
|
LGTM |
|
Thanks! Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Test Coverage for
WidenSetOperationTypes,BooleanEquality,StackCoercionandDivision, this is a Sub-tasks for SPARK-22722.How was this patch tested?
N/A