Skip to content

Conversation

@sarutak
Copy link
Member

@sarutak sarutak commented Aug 18, 2014

No description provided.

@SparkQA
Copy link

SparkQA commented Aug 18, 2014

QA tests have started for PR 2016 at commit 7b89201.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Aug 18, 2014

QA tests have finished for PR 2016 at commit 7b89201.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@sarutak sarutak changed the title [SPARK-3101] Flag variable in ApplicationMaster should be declared as volatile [SPARK-3101] Missing volatile annotation in ApplicationMaster Aug 19, 2014
@SparkQA
Copy link

SparkQA commented Aug 19, 2014

QA tests have started for PR 2016 at commit 92c25ca.

  • This patch merges cleanly.

@sarutak
Copy link
Member Author

sarutak commented Aug 19, 2014

#2022 changed ApplicationMaster and ExecutorLauncher so rebased this PR.

@SparkQA
Copy link

SparkQA commented Aug 19, 2014

QA tests have finished for PR 2016 at commit 92c25ca.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@JoshRosen
Copy link
Contributor

@vanzin @tgravescs If this is a good fix, you may want to incorporate it into #2020 yourselves (I don't want to create even more merge conflicts for you).

@vanzin
Copy link
Contributor

vanzin commented Aug 19, 2014

@JoshRosen already added to my code, will update PR shortly. Thanks for pointing it out.

@JoshRosen
Copy link
Contributor

@sarutak I think this has been subsumed by #2020, which was merged yesterday, so do you mind closing this pull request if all of your changes have been incorporated? Thanks!

@sarutak
Copy link
Member Author

sarutak commented Aug 28, 2014

@JoshRosen O.K, I close this PR.

@sarutak sarutak closed this Aug 29, 2014
@sarutak sarutak deleted the SPARK-3101 branch April 11, 2015 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants