[SPARK-22998][K8S] Set missing value for SPARK_MOUNTED_CLASSPATH in the executors #20193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #85816 has finished for PR 20193 at commit
|
Contributor
|
LGTM. This exists in our fork and was missed here. Good catch @liyinan926. |
Contributor
Author
|
@felixcheung so this change is still applicable if #20192 is merged. |
Member
|
yap I thought about it and it's fine. |
Contributor
Author
|
Yes, will review it. |
felixcheung
approved these changes
Jan 9, 2018
Member
felixcheung
left a comment
felixcheung
left a comment
There was a problem hiding this comment.
LGTM. will merge unless I hear otherwise
asfgit
pushed a commit
that referenced
this pull request
Jan 9, 2018
…he executors ## What changes were proposed in this pull request? The environment variable `SPARK_MOUNTED_CLASSPATH` is referenced in the executor's Dockerfile, where its value is added to the classpath of the executor. However, the scheduler backend code missed setting it when creating the executor pods. This PR fixes it. ## How was this patch tested? Unit tested. vanzin Can you help take a look? Thanks! foxish Author: Yinan Li <liyinan926@gmail.com> Closes #20193 from liyinan926/master. (cherry picked from commit 6a4206f) Signed-off-by: Felix Cheung <felixcheung@apache.org>
Member
|
merged to master/2.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The environment variable
SPARK_MOUNTED_CLASSPATHis referenced in the executor's Dockerfile, where its value is added to the classpath of the executor. However, the scheduler backend code missed setting it when creating the executor pods. This PR fixes it.How was this patch tested?
Unit tested.
@vanzin Can you help take a look? Thanks!
@foxish