Skip to content

[SPARK-23263][TEST] CTAS should update stat if autoUpdate statistics is enabled #20430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wangyum wants to merge 7 commits into from
Closed

[SPARK-23263][TEST] CTAS should update stat if autoUpdate statistics is enabled #20430

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
08d31c0
create table stored as parquet should update table size if automatic …
wangyum Jan 30, 2018
a37d28e
Merge remote-tracking branch 'upstream/master' into SPARK-23263
wangyum May 9, 2019
1c9caa0
Add test
wangyum May 9, 2019
36fd737
Merge remote-tracking branch 'upstream/master' into SPARK-23263
wangyum May 27, 2019
aa89871
Merge remote-tracking branch 'upstream/master' into SPARK-23263
wangyum Jun 14, 2019
c9949eb
Address comment
wangyum Jun 14, 2019
d4f9035
Fix error test: Seq(false, false) should be Seq(false, true)
wangyum Jun 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1431,4 +1431,26 @@ class StatisticsSuite extends StatisticsCollectionTestBase with TestHiveSingleto
assert(catalogStats.rowCount.isEmpty)
}
}

test(s"CTAS should update statistics if ${SQLConf.AUTO_SIZE_UPDATE_ENABLED.key} is enabled") {
val tableName = "SPARK_23263"
Seq(false, true).foreach { isConverted =>
Seq(false, true).foreach { updateEnabled =>
withSQLConf(
SQLConf.AUTO_SIZE_UPDATE_ENABLED.key -> updateEnabled.toString,
HiveUtils.CONVERT_METASTORE_PARQUET.key -> isConverted.toString) {
withTable(tableName) {
sql(s"CREATE TABLE $tableName STORED AS parquet AS SELECT 'a', 'b'")
val catalogTable = getCatalogTable(tableName)
// Hive serde tables always update statistics by Hive metastore
if (!isConverted || updateEnabled) {
assert(catalogTable.stats.nonEmpty)
} else {
assert(catalogTable.stats.isEmpty)
}
}
}
}
}
}
}