Skip to content

[SPARK-23364][SQL]'desc table' command in spark-sql add column head display #20557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guoxiaolongzte wants to merge 2 commits into from
Closed

[SPARK-23364][SQL]'desc table' command in spark-sql add column head display #20557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5699c0d
[SPARK-23364][SQL]'desc table' command in spark-sql add column head d…
Feb 9, 2018
cf38ca3
'Fetched * row(s)' correct display, no statistics head.
Feb 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,15 +539,15 @@ case class DescribeTableCommand(
throw new AnalysisException(
s"DESC PARTITION is not allowed on a temporary view: ${table.identifier}")
}
describeSchema(catalog.lookupRelation(table).schema, result, header = false)
describeSchema(catalog.lookupRelation(table).schema, result, header = true)
Copy link
Member

@wangyum wangyum Feb 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be should add a configure like hive.cli.print.header.

Copy link
Member

@srowen srowen Feb 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not worth yet another flag, and this is a behavior change in the output. There's no motivation for this change either.

Copy link
Member

@gatorsmile gatorsmile Feb 9, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For details, see #18203

Copy link
Author

@guoxiaolongzte guoxiaolongzte Feb 11, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partition Information

col_name data_type comment

Partition information also takes up two rows.
I try to keep the head of the case, let rows number is displayed correctly.

Copy link
Author

@guoxiaolongzte guoxiaolongzte Feb 11, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The snapshot is correct fix code effect, the statistics rows does not contain the head
2

Copy link
Member

@srowen srowen Feb 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gatorsmile I wasn't clear -- you're saying this change is wrong because it re-adds a header that was removed in the other PR?

Copy link
Member

@gatorsmile gatorsmile Feb 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Hive beeline already hardcoded the header. See the https://issues.apache.org/jira/browse/SPARK-20954

} else {
val metadata = catalog.getTableMetadata(table)
if (metadata.schema.isEmpty) {
// In older version(prior to 2.1) of Spark, the table schema can be empty and should be
// inferred at runtime. We should still support it.
describeSchema(sparkSession.table(metadata.identifier).schema, result, header = false)
} else {
describeSchema(metadata.schema, result, header = false)
describeSchema(metadata.schema, result, header = true)
}

describePartitionInfo(metadata, result)
Expand Down
4 changes: 3 additions & 1 deletion ...hriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIDriver.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,9 @@ private[hive] class SparkSQLCLIDriver extends CliDriver with Logging {
try {
while (!out.checkError() && driver.getResults(res)) {
res.asScala.foreach { l =>
counter += 1
if (!l.startsWith("#")) {
counter += 1
}
out.println(l)
}
res.clear()
Expand Down