Skip to content

[SPARK-3150] Fix NullPointerException in in Spark recovery: Add initializing default values in DriverInfo.init() #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tanyatik wants to merge 1 commit into from
Closed

[SPARK-3150] Fix NullPointerException in in Spark recovery: Add initializing default values in DriverInfo.init() #2062

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions core/src/main/scala/org/apache/spark/deploy/master/DriverInfo.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,17 @@ private[spark] class DriverInfo(
@transient var exception: Option[Exception] = None
/* Most recent worker assigned to this driver */
@transient var worker: Option[WorkerInfo] = None

init()

private def readObject(in: java.io.ObjectInputStream): Unit = {
in.defaultReadObject()
init()
}

private def init(): Unit = {
state = DriverState.SUBMITTED
worker = None
exception = None
}
Copy link
Contributor

@andrewor14 andrewor14 Aug 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I understand your intention. These are all transient and won't actually be serialized, so why do we need to set them every time we readObject?

Copy link
Contributor Author

@tanyatik tanyatik Aug 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a field is deserialized, transient fields become null value, not None, thats why NullPointerException happens.

Copy link
Contributor Author

@tanyatik tanyatik Aug 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar approach is used in WorkerInfo

Copy link
Contributor

@andrewor14 andrewor14 Aug 25, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, thanks for the context.

}