Skip to content

Conversation

@maropu
Copy link
Member

@maropu maropu commented Mar 13, 2018

What changes were proposed in this pull request?

This pr supported selective tests in SQLQueryTestSuite, e.g.,

SPARK_SQL_QUERY_TEST_FILTER=limit.sql,random.sql build/sbt "sql/test-only *SQLQueryTestSuite"

How was this patch tested?

Manually checked

@maropu
Copy link
Member Author

maropu commented Mar 13, 2018

This pr was split off from #20433 (comment)
cc: @gatorsmile

@SparkQA
Copy link

SparkQA commented Mar 13, 2018

Test build #88197 has finished for PR 20808 at commit 093f405.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu
Copy link
Member Author

maropu commented Mar 13, 2018

retest this please

@SparkQA
Copy link

SparkQA commented Mar 13, 2018

Test build #88201 has finished for PR 20808 at commit 093f405.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

* SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/test-only *SQLQueryTestSuite"
* }}}
*
* For selective tests, run:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not directly using something like

build/sbt "~sql/test-only *SQLQueryTestSuite -- -z inline-table.sql -z random.sql"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, I didn't know sbt can do. I usually use maven and it seems maven cannot do that. Anyway, it's okay to use `sbt for this case. Thanks!

@maropu maropu closed this Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants