Skip to content

[SPARK-23728][BRANCH-2.3] Fix ML tests with expected exceptions running streaming tests #20852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
attilapiros wants to merge 1 commit into from
Closed

[SPARK-23728][BRANCH-2.3] Fix ML tests with expected exceptions running streaming tests #20852

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions mllib/src/test/scala/org/apache/spark/ml/util/MLTest.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,15 @@ trait MLTest extends StreamTest with TempDirectory { self: Suite =>
expectedMessagePart : String,
firstResultCol: String) {

def hasExpectedMessageDirectly(exception: Throwable): Boolean =
exception.getMessage.contains(expectedMessagePart)

def hasExpectedMessage(exception: Throwable): Boolean =
exception.getMessage.contains(expectedMessagePart) ||
(exception.getCause != null && exception.getCause.getMessage.contains(expectedMessagePart))
hasExpectedMessageDirectly(exception) || (
exception.getCause != null && (
hasExpectedMessageDirectly(exception.getCause) || (
exception.getCause.getCause != null &&
hasExpectedMessageDirectly(exception.getCause.getCause))))
Copy link
Contributor

@WeichenXu123 WeichenXu123 Mar 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use a loop to check inner exception ? So it can check any deep level exception msg.
Maybe we cannot make sure the possible root exception max level (even in master version)
@jkbradley What do you think ?

Copy link
Member

@jkbradley jkbradley Mar 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to loop further. If the real message is buried this deep, that could be considered a problem in and of itself.


withClue(s"""Expected message part "${expectedMessagePart}" is not found in DF test.""") {
val exceptionOnDf = intercept[Throwable] {
Expand Down